App\Config\Routes loaded twice

[maddrid]

Describe the bug
App\Config\Routes file is loaded twice

CodeIgniter 4 version
All -Latest

Affected class
RouteCollection.
Codeigniter
Codeigniter->run () ---> handleRequest() --->tryToRouteIt () = require APPPATH .'Config/Routes.php';

** steps to reproduce **
Add a function to App\Config\Routes file

[lonnieezell]

Just did a quick scan of the codebase and it only appears to be loaded once. system/Config and any environment-specific files are also loaded.

The only way I can think of this happening otherwise is when it scans any namespaces for additional routes files it's not ignoring those two.

I'll try to look into this in the next few days.

[lonnieezell]

Cannot reproduce. Added:

function testme() { echo 'etest'; }

Into my routes file. Fired up the server (php spark serve) and loaded the page. No complaints about function already defined.

[maddrid]

just tested

CRITICAL - 2019-10-09 15:10:45 --> Cannot redeclare Config\test() (previously declared in N:\a\htdocs\ci\app\Config\Routes.php:78)
#0 [internal function]: CodeIgniter\Debug\Exceptions->shutdownHandler()
#1 {main}

[lonnieezell]

Is this on a clean install? You don't maybe have a helper being loaded with a similarly named function do you?

[maddrid]

Yes clean install . Just downloaded the latest version from here.
Tested again with various function names .
Also , the routes can be counted .
total routes = routes x 2

[lonnieezell]

@web-media what happens if you comment out the toolbar in app/Config/Filters.php?

[maddrid]

Commented the toolbar .

public $globals = [
		'before' => [
			//'honeypot'
			// 'csrf',
		],
		'after'  => [
		//	'toolbar',
			//'honeypot'
		],
	];

Works fine if no function in routes.php.
Error page if function added .

[MGatner]

Can you change it to this to get a little more helpful feedback on the what and when:

$routes->get('/', 'Home::index');

trace();
if (function_exists('cvvvv'))
{
	dd($routes);
}
function cvvvv() {'dsd';}

[maddrid]

<ROOT>/ci/app/Config/Routes.php:76 trace()

⇄→<ROOT>/ci/system/CodeIgniter.php:709 require()

⇄→<ROOT>/ci/system/CodeIgniter.php:295 CodeIgniter\CodeIgniter->tryToRouteIt(CodeIgniter\Router\RouteCollectionInterface $routes = null)

⇄→<ROOT>/ci/system/CodeIgniter.php:245 CodeIgniter\CodeIgniter->handleRequest(CodeIgniter\Router\RouteCollectionInterface $routes = null, $cacheConfig, bool $returnResponse = false)

⇄→<ROOT>/ci/public/index.php:45 CodeIgniter\CodeIgniter->run(CodeIgniter\Router\RouteCollectionInterface $routes = null, bool $returnResponse = false)

→ Called from /ci/app/Config/Routes.php:76

[MGatner]

Can you run it from CLI and put the output in PasteBin (or anywhere easier to read)?

php spark routes

[MGatner]

Initial reactions have me weirded out. I only see one Trace call in your screenshot when there should have been two, and unless I'm misunderstanding the parser I think that dd() should have been called before the second declaration of the function, which was not the case.