Work with entities and validation bug

[s524797336]

If model set $returnType="App\Entities\xxx" and validation with required_with[xxx]
Because entity have a protected var $datamap and have a array value.

See system/Validation/Rules on line 308
$requiredFields = array_intersect($fields, $data);
Because $data have a array datamap key so it will return a Array to string conversion exception
Is it a bug or i'm not using it right?

[lonnieezell]

Can you provide sample code just to make sure I understand and have something to test against?

[s524797336]

File: App\Entities\User

class User extends Entity{

protected $id;
protected $username;
protected $password;

}
Because CodeIgniter\Entity have a protected var $datamap on line 17 so this User class will inherit a protected var $datamap = [], right?

File: App\Models\UserModel

class UserModel extends \CodeIgniter\Model {

protected $table = 'user';
protected $primaryKey = 'id';
protected $returnType = 'App\Entities\User'; //set to use user entity
protected $validationRules = array(
	"pass_confirm" => "required_with[password]" //set this rule
);

}

When call save() method on this model
File: CodeIgniter\Validation\Rules on line 308
$requiredFields = array_intersect($fields, $data);
If print_r($data) before this line, will get this
Array ( [id] => [username] => xxx [password] => xxx [datamap] => Array ( ) )
So array_intersect will throw an error because datamap have a Array value

[s524797336]

save() method can receive a entry object, when call classToArray method then datamap will appear, not exclude datamap

[lonnieezell]

Doh! You're right. I'll look into it tonight and see if this is a deeper issue, or if we can just ignore that one. I have a feeling this might be a bigger issue for any class properties that are arrays...

[s524797336]

Class have a const keyword to set some setting value like this datamap, because this value is not change.
const datamap = array();
Why not use that, i like use this keyword to do a lot of things

[lonnieezell]

That wasn't the problem. The problem was in the validation rules.

With or without a const makes little difference here, but I'd like to leave the possibility for people to change that at runtime if they need to.

Pushing a fix now. Let me know if it works for you.