What are Config Files and how do we improve Config?

[kenjis]

I have questions about Config.

the current Routes file isn't what I would consider a config file
#7380 (comment)

Then, what are Config Files? or what are Config items?

Config items should be immutable or mutable?
We should use array for Config instead of class? What is the advantage of array-config?
App\Config causes infinite loop now (See #7308). How do we solve it?

Checking the environment variables for all properties when instantiating the Config class is too heavy.
This is one of the reasons why CI4 is slower than CI3. I want to improve this too.

[kenjis]

Forbid using the constructor in configs.
#7380 (comment)

What if I want to use a value in the database for a config value?

[lonnieezell]

I don't think this is a bug, so shouldn't it be discussed in the forums?

[lonnieezell]

What if I want to use a value in the database for a config value?

Config files are typically loaded before a database would be, so you hit issues there.

[kenjis]

I don't think this is a bug, so shouldn't it be discussed in the forums?

I don't think most maintainers see the forum.

And the source code is hard to read on the forum, and we can't just link to it and see the code like you can on GitHub. It's hard to have detailed discussions.

[kenjis]

Config files are typically loaded before a database would be, so you hit issues there.

Database seems working in Config\App.
See #4297 (comment)

[lonnieezell]

Database seems working in Config\App.

IIRC it will work for some config files but not others. Whichever ones that the database layer might grab will cause an issue, and that's more than just the database config file. I've ran into this in the past and I don't remember which specific ones caused the issue.

What if I want to use a value in the database for a config value?

The I recommending using CodeIgniter's official solution - Settings. :)

I don't think most maintainers see the forum.

They will see it on Slack, though. We've always told people Issues are for bug reports, forum was for feature requests.

[iRedds]

What if I want to use a value in the database for a config value?

First, I will give an example of Laravel.

1. Environment variables are loaded.
2. Configs are loaded.
3. ...
4. ServiceProviders are loaded (ServiceProviders register services in the container via the register() method)
5. For all loaded ServiceProviders, the boot() method is called.

There is an application ServiceProvider like AppServiceProvider. And in the AppServiceProvider::boot() method, you can add some logic that will definitely be called after the configs and before the request is processed.

I want to say that for the problem you described, there are several ways to solve it.

We need a class that will work in the same way as AppServiceProvider::boot()
Or, for these purposes, we can use the pre_system event, which is called immediately before the request is processed.

[iRedds]

I don't think this is a bug, so shouldn't it be discussed in the forums?

From my experience, I can say that the feedback from the CI team on the forum is close to zero. The only maintainer who is active is @kenjis . But as you can see, even he does not rely on the forum as a place for discussion.

[kenjis]

@iRedds My question is like this if using Laravel.
How do I set the values of Config files from the database data?
Probably I can't?

[kenjis]

We've always told people Issues are for bug reports, forum was for feature requests.

I think it is better to use GitHub Discussions if you don't like to use GitHub IIssues.

[iRedds]

@kenjis I am not using Laravel. I look at its code base to understand how these or those solutions are implemented.
I suppose that changes in configs at runtime in Laravel can be done as follows.

// config myconfig.php
return [
    'key' => 'default',
    'key2' => 'default2'
];

// AppServiceProvider
public function boot(): void
{
    // Here we override the config values, for example, by taking the values from the database.
    config(['myconfig.key' => 'new value']);
    // or for multiple keys
    config(['myconfig' => ['key' => 'new ', 'key2' => 'new 2']]);
}

// using 
Route::get('/', function () {
    dd(config('myconfig')); 
});

Now, by referring to the config, in the route we will receive the following data.

array:2 [▼ // routes\web.php:18
  "key" => "new "
  "key2" => "new 2"
]

[lonnieezell]

How do I set the values of Config files from the database data?

You can't, they are just simple arrays. You would need to do a separate layer, much like Settings does currently. f

From my experience, I can say that the feedback from the CI team on the forum is close to zero. The only maintainer who is active is @kenjis . But as you can see, even he does not rely on the forum as a place for discussion.

That's why we have a Slack channel for the core team. Discussions could happen there and if there was a need for input on the forums we could be pointed that way with a Slack message. I just feel that if we have been telling users that Issues are for bugs, we should listen to that advice ourselves.

[lonnieezell]

Back to the original discussion, though:

App\Config causes infinite loop now (See #7308). How do we solve it?

We don't. There is no need for session with a config file, as a config file is intended to hold the settings that configure how the application works and not respond to each user's individual session settings.

We should use array for Config instead of class?

I'm not opposed to going back to this for v5. We obviously cannot do it earlier. It would be lighter than the class-based configuration we currently use, and better for memory as optimized as PHPs arrays are now. I don't know how much the performance gains would be, compared to the database layer, which is our slowest part of the framework now, I believe.

There are a few config classes that provide methods that would have to be moved elsewhere. To be honest, though, I've only ever heard a couple people mentioning it being an issue, so we would need to consider the pros/cons/cost in manpower, and I think it would be good to get a bigger set of opinions on the forums. There's probably several topics we should do that about so we can start actually planning for v5 more.

Checking the environment variables for all properties when instantiating the Config class is too heavy.

IIRC the loading of environment vars only happens once, and would still need to happen with an array-based config. I haven't measured the cost of looping over the class vars in each class, but I would be surprised if it was too onerous. Would be interesting to see benchmarking on that.