fix: reject unsupported database drivers in make:migration --session - #10546
Open
paulbalandan wants to merge 1 commit into
Open
fix: reject unsupported database drivers in make:migration --session#10546paulbalandan wants to merge 1 commit into
make:migration --session#10546paulbalandan wants to merge 1 commit into
Conversation
paulbalandan
force-pushed
the
session-migration-driver
branch
from
September 12, 2026 14:22
9dcca87 to
5c43b65
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Discovered on #10545 . A smoke run of
--sessionagainst a SQLite3 group produced a migration that cannot run, so this fixes the underlying bug ondevelopfirst.make:migration --sessionrenders the session table columns only forMySQLiandPostgre. For any other driver the template falls through and the command silently writes a migration that indexes atimestampcolumn it never defined:The user only finds out when
spark migratefails. The per-driver split is deliberate (8600032):DatabaseHandlerwritestimestampwith rawnow(), so the column must be a real timestamp type, and the user guide already limits database sessions to MySQL and PostgreSQL. What was missing is a refusal for everything else.The command now checks the group's
DBDriverbefore generating and returnsEXIT_ERRORwith a message naming the group and driver. An undefined group is reported too instead of raising an undefined-property warning.New language strings:
CLI.generator.undefinedDatabaseGroupandCLI.generator.unsupportedSessionDriver.Checklist: