Optimize Autoloader#3964
Closed
mostafakhudair wants to merge 5 commits into
Closed
Conversation
Member
|
Have you been able to measure this and see if it helps at all? I only ask because I tried some other optimizations around this early on and found that PHP's file location cache is actually really good, and the gains were extremely minimal and just added complexity to the framework. |
samsonasik
reviewed
Dec 5, 2020
| $class = str_ireplace('.php', '', trim($class, '\\')); | ||
|
|
||
| $mapped_file = $this->loadInNamespace($class); | ||
| $mappedFile = $this->loadInNamespace($class); |
Member
There was a problem hiding this comment.
use underscore on purpose as removed in 4.1, not worth updated for conflict, see rector.php config to skip this file for check underscore to camelcase check
Member
|
I think this has some good content but at this point I'd rather see |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimize Autoloader Filelocator classes
add new Autoloader method
loadClassmap()that registers classmap files with autoloaderChecklist: