Skip to content

Refactor ComposerScripts - #4634

Merged
paulbalandan merged 1 commit into
codeigniter4:developfrom
paulbalandan:refactor-composer-scripts
May 2, 2021
Merged

paulbalandan merged 1 commit into
codeigniter4:developfrom
paulbalandan:refactor-composer-scripts

Conversation

@paulbalandan

Copy link
Copy Markdown
Member

Description
Refactor CodeIgniter\ComposerScripts to make it a little performant while allowing new direct dependencies to be added with ease.

This class is technically a "development" class so this can be changed at will without worrying for BC breaks.

Checklist:

  • Securely signed commits
  • Tested locally. Git status is clean.

@MGatner

MGatner commented May 1, 2021

Copy link
Copy Markdown
Member

This is definitely an improvement. I have been wanting to add a Publisher component to the framework for some time. It would mostly handle moving files from vendor into various parts of a project. This could be to facilitate patching the app/ folder (like Patches and Liaison Revision) or to push necessary assets into public/; I could also see it being useful here.

If this is something you'd have interest in taking on then it could supersede these changes, but if that's beyond your current scope we can proceed with this.

@paulbalandan

Copy link
Copy Markdown
Member Author

This is definitely an improvement. I have been wanting to add a Publisher component to the framework for some time. It would mostly handle moving files from vendor into various parts of a project. This could be to facilitate patching the app/ folder (like Patches and Liaison Revision) or to push necessary assets into public/; I could also see it being useful here.

If this is something you'd have interest in taking on then it could supersede these changes, but if that's beyond your current scope we can proceed with this.

It appears to be a good addition but I cannot commit myself to be working on this in the coming days/weeks. Maybe we can add this to the "Nice to Have" and look back into it when time permits.

@MGatner MGatner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries! I'm planning to work on it when I get a chance, I need it for a few projects and modules. Thanks for this PR, some really good improvements in here.

@paulbalandan
paulbalandan merged commit 042184b into codeigniter4:develop May 2, 2021
@paulbalandan
paulbalandan deleted the refactor-composer-scripts branch May 2, 2021 13:04
@MGatner MGatner mentioned this pull request May 24, 2021
5 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants