allow for folders for file caching

[colethorsen]

Each pull request should address a single issue and have a meaningful title.

Description
Fix the previous breaking change that prevents folders from being created for file based caching allow folders for file caching increases performance and organization when there are significant numbers of cached files.

Checklist:

• Securely signed commits
• Component(s) with PHPdocs
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

---------Remove from here down in your description----------

Notes

• Pull requests must be in English
• If the PR solves an issue, reference it with a suitable verb and the issue number
  (e.g. fixes 12345)
• Unsolicited pull requests will be considered, but there is no guarantee of acceptance
• Pull requests should be from a feature branch in the contributor's fork of the repository
  to the develop branch of the project repository

[MGatner]

I'll admit I had no idea FileHandler was working with subdirectories, but I don't believe that was intended. This breaks on a few levels:

• clean() only removes files in the top-level directory, meaning sub-directory items are never cleared
• getCacheInfo() only reads from the top-level directory, meaning sub-directory items are not included in the assessment

This driver was ported from CI3 and I don't see docs in either versions referencing sub-directories. I believe this was an "accidental feature" but given that it was also accidentally buggy I'm not sure that we want to reinstate it, at least not without doing it properly. @lonnieezell ported the driver, let's see if he knows more.

[colethorsen]

You also can't just remove a feature/bug/whatever you want to call it that production applications are relying on without a proper deprecation cycle, and without a proper solution to the problem that subdirectories fix. i.e. it could just be built to automatically subdirectory based on the first x characters in the string or something similar.

[MGatner]

You also can't just remove ... that production applications are relying

Agreed. Like I said this was totally unintentional, but I believe that is because the feature was unintentional to begin with (or at least entirely undocumented/commented). We can make this a priority but I'm not comfortable making this call by myself. If you have time and capacity to flesh out this PR to be a proper "allow subdirectories" emendation it would save time if we go that route.

[colethorsen]

I’m not suggesting you put it back permenantly but by implementing this hotfix solves the problem short term so people can upgrade without breaking entire systems (the other functionality would have always been broken for them anyways) and then working on a long term solution that solves the problem would be secondary. On Wed, Jun 2, 2021 at 8:50 AM, MGatner ***@***.***> wrote: You also can't just remove ... that production applications are relying Agreed. Like I said this was totally unintentional, but I believe that is because the feature was unintentional to begin with (or at least entirely undocumented/commented). We can make this a priority but I'm not comfortable making this call by myself. If you have time and capacity to flesh out this PR to be a proper "allow subdirectories" emendation it would save time if we go that route. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub [#4765 (comment)] , or unsubscribe [https://github.com/notifications/unsubscribe-auth/AAHKIMWLQU4MMB5CTP4HPK3TQZHMRANCNFSM455PCAJA] .

[MGatner]

We for sure won't be hotfixing (i.e. pushing to master and re-releasing). If you mean providing this solution in the repo you can do this with the content you already made by pointing at your branch. Update composer.json as follows:

	"require": {
		"php": "^7.3 || ^8.0",
		"codeigniter4/codeigniter4": "dev-feature/fix-file-cache",
	},
	"repositories": [
		{
			"type": "vcs",
			"url": "https://github.com/colethorsen/codeigniter4"
		}
	]

The forums are back up. If you PM me your Slack email I will invite you directly.

[paulbalandan]

Superseded by #5008