Fix lang() function overriding default locale in Language class - #5001
Merged
Merged
Conversation
MGatner
approved these changes
Aug 15, 2021
MGatner
left a comment
MGatner
left a comment
Member
There was a problem hiding this comment.
Looks good! Thanks for changing that. There are a few style issues but this whole branch needs to be run through CS Fixer once it is ready so not a big deal - just mind it for the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After using the
lang()function with the$localeparameter filled in, it overrides the default locale in the Language class, which shouldn't happen, because when using thelang()function with the$localeparameter it should be just for that call.With this change, this override is corrected and the locale that was previously selected is restored.
Checklist: