feat: New method DownloadResponse::inline() - #7207
Merged
Merged
Conversation
michalsn
approved these changes
Feb 2, 2023
kenjis
reviewed
Feb 3, 2023
kenjis
reviewed
Feb 3, 2023
kenjis
reviewed
Feb 3, 2023
Member
|
Thank you. This seems good. Please update the user guide a bit. |
kenjis
reviewed
Feb 3, 2023
kenjis
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There is currently no way to change the
Content-Dispositionheader when downloading a file, as this header will be overwritten when generating headers in theDownloadResponseclass.This PR prevents the
Content-Dispositionheader from being changed when generating headers if that header has already been set.It also adds a
DownloadRespone::inline()helper method that sets theContent-Disposition: inlineheader.Checklist: