Skip to content

Enhance: [MySQLi] use MYSQLI_OPT_INT_AND_FLOAT_NATIVE - #7260

Closed
kai890707 wants to merge 1 commit into
codeigniter4:developfrom
kai890707:enhance-sql-return-type
Closed

kai890707 wants to merge 1 commit into
codeigniter4:developfrom
kai890707:enhance-sql-return-type

Conversation

@kai890707

Copy link
Copy Markdown
Contributor

Description
See #7259

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the database Issues or pull requests that affect the database layer label Feb 16, 2023
@kenjis

kenjis commented Feb 16, 2023

Copy link
Copy Markdown
Member

Thank you for sending PR!

This is a breaking change, so we don't accept this in develop.

I think this should be configurable in Database Config for MySQLi,
https://codeigniter4.github.io/CodeIgniter4/database/configuration.html#explanation-of-values
and this is an enhancement so this PR should go to 4.4 branch.
https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/workflow.md#if-you-sent-to-the-wrong-branch

@codeigniter4/database-team
Opinions?

@kenjis kenjis added wrong branch PRs sent to wrong branch enhancement PRs that improve existing functionalities labels Feb 16, 2023
@kenjis

kenjis commented Feb 16, 2023

Copy link
Copy Markdown
Member

@kenjis kenjis changed the title Enhance: Change the return type to follow the db field type. Enhance: [MySQLi] Change the return type to follow the db field type. Feb 16, 2023
@kenjis kenjis changed the title Enhance: [MySQLi] Change the return type to follow the db field type. Enhance: [MySQLi] use MYSQLI_OPT_INT_AND_FLOAT_NATIVE Feb 16, 2023
@kenjis kenjis added the GPG-Signing needed Pull requests that need GPG-Signing label Feb 16, 2023
@kai890707 kai890707 closed this by deleting the head repository Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

database Issues or pull requests that affect the database layer enhancement PRs that improve existing functionalities GPG-Signing needed Pull requests that need GPG-Signing wrong branch PRs sent to wrong branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants