refactor: remove unused non-empty array in RequestTrait - #7606
Closed
paulbalandan wants to merge 1 commit into
Closed
paulbalandan wants to merge 1 commit into
paulbalandan wants to merge 1 commit into
Conversation
Member
|
The CodeIgniter4/app/Config/App.php Lines 341 to 346 in 9d95248 In this case, this change causes: |
Member
Author
|
Ok. Judging by how |
Member
|
It is better to set Or add "$proxyIPs must be an array" to Mandatory File Changes in the upgrade guide. |
This was referenced Jun 26, 2023
Merged
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Brought by
RemoveUnusedNonEmptyArrayBeforeForeachRectorbut manually made as I cannot use rector on Windows.Checklist: