Skip to content

docs: [4.4] fix Rector's incorrect refactoring #7650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samsonasik merged 1 commit into from
Jul 6, 2023
Merged

docs: [4.4] fix Rector's incorrect refactoring #7650

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions system/Router/AutoRouterImproved.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@ final class AutoRouterImproved implements AutoRouterInterface

/**
* An array of params to the controller method.
*
* @phpstan-var list<string>
*/
private array $params = [];

Expand All @@ -72,6 +74,8 @@ final class AutoRouterImproved implements AutoRouterInterface

/**
* The URI segments.
*
* @phpstan-var list<string>
*/
private array $segments = [];

Expand Down Expand Up @@ -279,6 +283,7 @@ public function getRoute(string $uri, string $httpVerb): array
}

// The first item may be a method name.
/** @phpstan-var list<string> $params */
$params = $this->params;

$methodParam = array_shift($params);
Expand Down