fix: remove instantiation of Response in Services::exceptions() - #7670
Merged
Merged
Conversation
kenjis
added
bug
kenjis
force-pushed
the
fix-Services-exceptions
branch
from
July 29, 2023 06:07
7ef1efa to
9770d3b
Compare
Member
Author
|
Rebased to resolve conflict. |
kenjis
force-pushed
the
fix-Services-exceptions
branch
from
August 2, 2023 02:28
9770d3b to
1b09623
Compare
Member
Author
|
Rebased to resolve conflict. This is a simple PR. Can someone review? |
paulbalandan
approved these changes
Aug 2, 2023
datamweb
approved these changes
Aug 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In 4.3 or before, Request and Response objects are created in
Services::exceptions()inCodeIgniter::initialize(). It is too early, and it created bug #7668.In 4.4 branch, we have already removed instantiation of Request in
Services::exceptions().This PR removes the instantiation of Response, and both Request and Response objects will be created in
CodeIgniter::run().Checklist: