Return signatures of Autoloader's loaders should be void - #7747
Merged
Merged
Conversation
paulbalandan
force-pushed
the
autoloader-loader
branch
from
July 29, 2023 14:50
a841c6e to
14d7221
Compare
mostafakhudair
approved these changes
Jul 29, 2023
Member
|
@paulbalandan I don't see the benefit. I don't think this is a bug. I think adding |
Member
Author
|
The signature is in the Parameters section:
Okay, I'll send to |
paulbalandan
force-pushed
the
autoloader-loader
branch
from
July 30, 2023 11:36
14d7221 to
31b79b1
Compare
Member
|
@paulbalandan Okay, the callback return type should be |
kenjis
reviewed
Jul 31, 2023
paulbalandan
force-pushed
the
autoloader-loader
branch
from
August 1, 2023 10:39
31b79b1 to
f075b7c
Compare
kenjis
approved these changes
Aug 2, 2023
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ref: https://www.php.net/manual/en/function.spl-autoload-register.php
As a result of this change, this may be a potential BC break. I added this to the changelog. Also marked
@internalthose 2 callbacks.Checklist: