Skip to content

fix: add types to View $filters and $plugins - #7885

Merged
kenjis merged 1 commit into
codeigniter4:developfrom
paulbalandan:phpstan-view-types
Sep 7, 2023
Merged

kenjis merged 1 commit into
codeigniter4:developfrom
paulbalandan:phpstan-view-types

Conversation

@paulbalandan

@paulbalandan paulbalandan commented Aug 31, 2023

Copy link
Copy Markdown
Member

Description
See #7731

References:

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandan
paulbalandan force-pushed the phpstan-view-types branch 2 times, most recently from 5174ed7 to f184d83 Compare August 31, 2023 06:53

@kenjis kenjis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a little research, but could not find a way to eliminate the Psalm errors.

@kenjis
kenjis merged commit 93670c5 into codeigniter4:develop Sep 7, 2023
@paulbalandan
paulbalandan deleted the phpstan-view-types branch September 8, 2023 01:06
@kenjis kenjis added the refactor Pull requests that refactor code label Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Pull requests that refactor code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants