Skip to content

test: use PHP_VERSION_ID instead of PHP_VERSION - #7913

Merged
kenjis merged 1 commit into
codeigniter4:developfrom
kenjis:test-refactor-PHP_VERSION
Sep 8, 2023
Merged

kenjis merged 1 commit into
codeigniter4:developfrom
kenjis:test-refactor-PHP_VERSION

Conversation

@kenjis

@kenjis kenjis commented Sep 8, 2023

Copy link
Copy Markdown
Member

Description
To make the code easy to understand.

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis added testing Pull requests that changes tests only refactor Pull requests that refactor code labels Sep 8, 2023
@datamweb

datamweb commented Sep 8, 2023

Copy link
Copy Markdown
Contributor

How about index.php, spark ?

@kenjis

kenjis commented Sep 8, 2023

Copy link
Copy Markdown
Member Author

Of course, you or anyone can refactor.

@neznaika0

Copy link
Copy Markdown
Contributor

and Autoloader

if (version_compare(PHP_VERSION, '8.0.0', '>=')) {

@kenjis
kenjis merged commit 64c9a70 into codeigniter4:develop Sep 8, 2023
@kenjis
kenjis deleted the test-refactor-PHP_VERSION branch September 8, 2023 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Pull requests that refactor code testing Pull requests that changes tests only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants