refactor: remove $_SESSION from methods and functions - #7982
Merged
kenjis merged 4 commits intoOct 3, 2023
Merged
Conversation
pjsde
force-pushed
the
refactor-session-constant-usage
branch
from
September 26, 2023 19:37
a054a4a to
223d5fe
Compare
kenjis
reviewed
Sep 27, 2023
pjsde
force-pushed
the
refactor-session-constant-usage
branch
3 times, most recently
from
September 28, 2023 10:09
d9c23cc to
e1e8c86
Compare
kenjis
approved these changes
Sep 29, 2023
kenjis
left a comment
Member
There was a problem hiding this comment.
This is an improvement.
Thank you.
Member
|
@pjsde We do not include merge commits in PR branches. |
Co-authored-by: Mostafa Khudair <59371810+mostafakhudair@users.noreply.github.com>
pjsde
force-pushed
the
refactor-session-constant-usage
branch
from
October 2, 2023 08:40
2b4ef45 to
b5d123a
Compare
Contributor
Author
kenjis
approved these changes
Oct 3, 2023
Member
|
@pjsde Thank you! Glad you are able to use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Functions and methods should not directly call the
$_SESSIONarray but use thesession()helper to obtain their contents from theServices::Sessionlibrary.This avoids the need to override code if someone needs to organize the
$_SESSIONarray in another way.Checklist: