Skip to content

fix: Services::request() should call AppServices instead static - #7985

Merged
kenjis merged 1 commit into
codeigniter4:developfrom
pjsde:fix-services-request
Sep 28, 2023
Merged

kenjis merged 1 commit into
codeigniter4:developfrom
pjsde:fix-services-request

Conversation

@pjsde

@pjsde pjsde commented Sep 26, 2023

Copy link
Copy Markdown
Contributor

CodeIgniter\Config\Services::request() should return Config\Services::incomingrequest() instead of static::incomingrequest() to allow override the IncomingRequest

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Sep 27, 2023
@kenjis
kenjis merged commit f62e6cf into codeigniter4:develop Sep 28, 2023
@kenjis

kenjis commented Sep 28, 2023

Copy link
Copy Markdown
Member

@pjsde Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Verified issues on the current code behavior or pull requests that will fix them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants