Skip to content

refactor: if condition in OCI8/Connection.php - #7994

Merged
kenjis merged 1 commit into
codeigniter4:developfrom
kenjis:refactor-OCI8-Connection-if
Oct 3, 2023
Merged

kenjis merged 1 commit into
codeigniter4:developfrom
kenjis:refactor-OCI8-Connection-if

Conversation

@kenjis

@kenjis kenjis commented Sep 30, 2023

Copy link
Copy Markdown
Member

Description
To fix PHPStan error.
See https://github.com/codeigniter4/CodeIgniter4/actions/runs/6358613550/job/17271052582

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis added the refactor Pull requests that refactor code label Sep 30, 2023
@kenjis
kenjis merged commit e67b42a into codeigniter4:develop Oct 3, 2023
@kenjis
kenjis deleted the refactor-OCI8-Connection-if branch October 3, 2023 05:27
@kenjis

kenjis commented Oct 3, 2023

Copy link
Copy Markdown
Member Author

@neznaika0 Thank you for review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Pull requests that refactor code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants