fix: reverse route for '' is not false - #8024
Merged
Merged
Conversation
The routes should be loaded before tests.
'' is invalid'' is not false
michalsn
approved these changes
Oct 10, 2023
MGatner
reviewed
Oct 12, 2023
MGatner
left a comment
Member
There was a problem hiding this comment.
Can you provide more justification why '' would not logically be the route to "default URL"? I assume '/' already is. There is some precedent in RFCs to treat these as identical.
Member
Author
|
@MGatner This is about Reverse Routing, not URI path. The |
Member
|
Ohhh sorry, didn't read closely enough! Yes clearly a bug, thanks for clarifying. |
MGatner
approved these changes
Oct 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
By default, the following code returns
http://localhost:8080/index.php/(the first route).There is a test case for an empty string:
CodeIgniter4/tests/system/Helpers/URLHelper/MiscUrlTest.php
Line 866 in 0d94606
But it passes because no route is registered at the test execution.
Checklist: