Skip to content

fix: CSP style nonce is added even if honeypot is not attached - #8025

Merged
kenjis merged 2 commits into
codeigniter4:developfrom
kenjis:fix-Honeypot-CSP-style-nonce
Oct 13, 2023
Merged

kenjis merged 2 commits into
codeigniter4:developfrom
kenjis:fix-Honeypot-CSP-style-nonce

Conversation

@kenjis

@kenjis kenjis commented Oct 10, 2023

Copy link
Copy Markdown
Member

Description
Fixes #8020
See #8020 (comment)

The tag like this was added before </head> tag in every page.

<style nonce="ccdd15247e8da0a5b9023a5e">#hpc { display:none }</style>

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Oct 10, 2023
The tag like this was added in <head> tag in every page.
<style nonce="ccdd15247e8da0a5b9023a5e">#hpc { display:none }</style>
@kenjis
kenjis force-pushed the fix-Honeypot-CSP-style-nonce branch from 4b3dc87 to 4892849 Compare October 10, 2023 07:51

@MGatner MGatner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick turnaround!

@kenjis
kenjis merged commit 617180a into codeigniter4:develop Oct 13, 2023
@kenjis
kenjis deleted the fix-Honeypot-CSP-style-nonce branch October 13, 2023 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Verified issues on the current code behavior or pull requests that will fix them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HoneyPot CSS Style nonce (when using CSP) does not work with Web Page Caching

3 participants