Skip to content

fix: named routes don't work with spark - #8028

Merged
kenjis merged 1 commit into
codeigniter4:developfrom
kenjis:fix-spark-named-routes
Oct 13, 2023
Merged

kenjis merged 1 commit into
codeigniter4:developfrom
kenjis:fix-spark-named-routes

Conversation

@kenjis

@kenjis kenjis commented Oct 11, 2023

Copy link
Copy Markdown
Member

Description
Fixes #8027

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Oct 11, 2023

@michalsn michalsn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's working. Thank you.

Can we expect the release of 4.4.2 in the near future? That would be great.

@kenjis

kenjis commented Oct 11, 2023

Copy link
Copy Markdown
Member Author

Once these bugs are fixed,, I would like to release v4.4.2.
https://github.com/codeigniter4/CodeIgniter4/pulls?q=is%3Apr+is%3Aopen+label%3Abug+-label%3A4.5+author%3Akenjis

@kenjis
kenjis merged commit 586b9f2 into codeigniter4:develop Oct 13, 2023
@kenjis
kenjis deleted the fix-spark-named-routes branch October 13, 2023 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Verified issues on the current code behavior or pull requests that will fix them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: named routes doesn't work in CLI

3 participants