fix: add a primary key to an existing table - #8031
Merged
Merged
Conversation
kenjis
added
the
bug
Member
|
On $ vendor/bin/phpunit tests/system/Database/Live/ForgeTest.php
PHPUnit 9.6.13 by Sebastian Bergmann and contributors.
Runtime: PHP 8.1.24
Configuration: /.../CodeIgniter4/phpunit.xml
............................................F. 46 / 46 (100%)
...
Time: 00:44.055, Memory: 18.00 MB
There was 1 failure:
1) CodeIgniter\Database\Live\ForgeTest::testProcessIndexesWithPrimaryKeyOnly
Failed asserting that actual size 0 matches expected size 1.
/.../CodeIgniter4/tests/system/Database/Live/ForgeTest.php:1705
FAILURES!
Tests: 46, Assertions: 112, Failures: 1. |
MGatner
approved these changes
Oct 12, 2023
MGatner
left a comment
MGatner
left a comment
Member
There was a problem hiding this comment.
You get my rare database-related approval 😉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #8019
Checklist: