Skip to content

[Rector] Apply SingleInArrayToCompareRector - #8102

Merged
samsonasik merged 1 commit into
codeigniter4:developfrom
samsonasik:single-in-array
Oct 27, 2023
Merged

samsonasik merged 1 commit into
codeigniter4:developfrom
samsonasik:single-in-array

Conversation

@samsonasik

Copy link
Copy Markdown
Member

Description

Changes in_array() with single element to identical check.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@samsonasik

Copy link
Copy Markdown
Member Author

Ready to merge 👍

@kenjis kenjis added the refactor Pull requests that refactor code label Oct 27, 2023
@samsonasik
samsonasik merged commit c6d9179 into codeigniter4:develop Oct 27, 2023
@samsonasik

Copy link
Copy Markdown
Member Author

Thank you @paulbalandan @kenjis for the review 👍

@samsonasik
samsonasik deleted the single-in-array branch October 27, 2023 06:44

@MGatner MGatner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kinda makes you wonder how some of these got here to begin with 😅 Thanks for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Pull requests that refactor code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants