fix: change make:command default $group to App - #8109
Merged
Merged
Conversation
`CodeIgniter` is already used for the framework commands. CodeIgniter env Retrieves the current environment, or set a new one. filter:check Check filters for a route. help Displays basic usage information. list Lists the available commands. namespaces Verifies your namespaces are setup correctly. publish Discovers and executes all predefined Publisher classes. routes Displays all routes. serve Launches the CodeIgniter PHP-Development Server.
kenjis
added
the
bug
michalsn
approved these changes
Oct 28, 2023
MGatner
approved these changes
Oct 28, 2023
MGatner
left a comment
MGatner
left a comment
Member
There was a problem hiding this comment.
Oh yes definitely a good change. We should probably be reserving the framework group due to security concerns, but this is a good step.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
CodeIgniteris already used for the framework commands.Checklist: