Skip to content

fix: @return in filter.tpl.php - #8145

Merged
kenjis merged 1 commit into
codeigniter4:developfrom
kenjis:fix-types-in-filter.tpl.php
Nov 7, 2023
Merged

kenjis merged 1 commit into
codeigniter4:developfrom
kenjis:fix-types-in-filter.tpl.php

Conversation

@kenjis

@kenjis kenjis commented Nov 4, 2023

Copy link
Copy Markdown
Member

Description
See #6310

  • fix @return in filter.tpl.php

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Nov 4, 2023

@michalsn michalsn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why null is not an option?

@kenjis

kenjis commented Nov 7, 2023

Copy link
Copy Markdown
Member Author

Because there is not null in the interface.

* @return RequestInterface|ResponseInterface|string|void

The fewer types the better. is there any reason why we need null?

@MGatner

MGatner commented Nov 7, 2023

Copy link
Copy Markdown
Member

null/void is kind of a bogus return type distinction in PHP. I think matching the interface is the way to go.

@michalsn

michalsn commented Nov 7, 2023

Copy link
Copy Markdown
Member

The fewer types the better. is there any reason why we need null?

Nah, I haven't checked the interface. Sounds good. I probably saw null somewhere else.

@kenjis
kenjis merged commit 46ab4c6 into codeigniter4:develop Nov 7, 2023
@kenjis
kenjis deleted the fix-types-in-filter.tpl.php branch November 7, 2023 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Verified issues on the current code behavior or pull requests that will fix them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants