Skip to content

fix: when request body is 0, $body will be null - #8161

Merged
kenjis merged 5 commits into
codeigniter4:developfrom
kenjis:fix-Request-body-0
Nov 7, 2023
Merged

fix: when request body is 0, $body will be null#8161
kenjis merged 5 commits into
codeigniter4:developfrom
kenjis:fix-Request-body-0

Conversation

@kenjis

@kenjis kenjis commented Nov 7, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Description

  • fix bug that when request body is 0, $body will be null

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Nov 7, 2023
@kenjis kenjis mentioned this pull request Nov 7, 2023
Merged
5 tasks
MGatner
MGatner approved these changes Nov 7, 2023
View reviewed changes

@MGatner MGatner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty() may have been the biggest mistake in all of PHP history.

@kenjis
kenjis merged commit 0708fd7 into codeigniter4:develop Nov 7, 2023
@kenjis
kenjis deleted the fix-Request-body-0 branch November 7, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michalsn michalsn michalsn approved these changes
@MGatner MGatner MGatner approved these changes

Assignees

No one assigned

Labels

bug Verified issues on the current code behavior or pull requests that will fix them

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kenjis @michalsn @MGatner