Skip to content

fix: spark routes outputs <unknown> only when {locale} with useSupportedLocalesOnly(true) - #8167

Merged
kenjis merged 1 commit into
codeigniter4:developfrom
kenjis:fix-spark-routes-useSupportedLocalesOnly
Nov 8, 2023
Merged

kenjis merged 1 commit into
codeigniter4:developfrom
kenjis:fix-spark-routes-useSupportedLocalesOnly

Conversation

@kenjis

@kenjis kenjis commented Nov 7, 2023

Copy link
Copy Markdown
Member

Description
Fixes #7997
See #7997 (comment)

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Nov 7, 2023

@neznaika0 neznaika0 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to be working. However, this is not how we planned. Oh, well

@kenjis
kenjis merged commit 4057489 into codeigniter4:develop Nov 8, 2023
@kenjis
kenjis deleted the fix-spark-routes-useSupportedLocalesOnly branch November 8, 2023 21:54
@kenjis kenjis changed the title fix: spark routes outputs <unknown> only when {locale} with useSupportedLocalesOnly(true) fix: spark routes outputs <unknown> only when {locale} with useSupportedLocalesOnly(true) Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Verified issues on the current code behavior or pull requests that will fix them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: [Command] spark routes for routes containing {locale} return unknown filters

3 participants