Skip to content

docs: make note for spark routes and filters more accurate - #8178

Merged
kenjis merged 1 commit into
codeigniter4:developfrom
kenjis:docs-fix-routes-filter-output
Nov 10, 2023
Merged

docs: make note for spark routes and filters more accurate#8178
kenjis merged 1 commit into
codeigniter4:developfrom
kenjis:docs-fix-routes-filter-output

Conversation

@kenjis

@kenjis kenjis commented Nov 8, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Description
The current description is inaccurate.

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • User guide updated
  • [] Conforms to style guide

@kenjis kenjis added the documentation Pull requests for documentation only label Nov 8, 2023
@kenjis kenjis mentioned this pull request Nov 8, 2023
Closed
5 tasks
datamweb
datamweb approved these changes Nov 9, 2023
View reviewed changes

@datamweb datamweb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice explanation.👍

@kenjis
kenjis merged commit 0ab4d67 into codeigniter4:develop Nov 10, 2023
@kenjis
kenjis deleted the docs-fix-routes-filter-output branch November 10, 2023 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michalsn michalsn michalsn approved these changes
+1 more reviewer
@datamweb datamweb datamweb approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

documentation Pull requests for documentation only

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kenjis @michalsn @datamweb