Skip to content

fix: force_https() redirects to wrong URL when baseURL has subfolder - #8191

Merged
kenjis merged 2 commits into
codeigniter4:developfrom
kenjis:fix-force_https
Nov 16, 2023
Merged

kenjis merged 2 commits into
codeigniter4:developfrom
kenjis:fix-force_https

Conversation

@kenjis

@kenjis kenjis commented Nov 11, 2023

Copy link
Copy Markdown
Member

Description
Fixes #8190

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Nov 11, 2023
@kenjis
kenjis force-pushed the fix-force_https branch 2 times, most recently from 3e46628 to 2751f48 Compare November 12, 2023 02:16
@kenjis
kenjis force-pushed the fix-force_https branch 2 times, most recently from a760dbf to 486bcc7 Compare November 12, 2023 07:44
@kenjis
kenjis marked this pull request as draft November 12, 2023 10:48
@kenjis
kenjis force-pushed the fix-force_https branch 2 times, most recently from d268ba0 to afcdcfc Compare November 12, 2023 11:07
@kenjis kenjis closed this Nov 12, 2023
@kenjis kenjis reopened this Nov 12, 2023
@kenjis
kenjis marked this pull request as ready for review November 12, 2023 11:07

@datamweb datamweb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions github-actions Bot added the stale Pull requests with conflicts label Nov 14, 2023
@github-actions

Copy link
Copy Markdown

👋 Hi, @kenjis!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

@kenjis kenjis removed the stale Pull requests with conflicts label Nov 14, 2023
@kenjis
kenjis merged commit 6a7fd1e into codeigniter4:develop Nov 16, 2023
@kenjis
kenjis deleted the fix-force_https branch November 16, 2023 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Verified issues on the current code behavior or pull requests that will fix them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Forcing Global Secure Requests does not work when the baseURL has more than a scheme and an authority

3 participants