Skip to content

fix: make Request::getEnv() deprecated - #8234

Merged
kenjis merged 3 commits into
codeigniter4:developfrom
kenjis:fix-request-getEnv
Nov 22, 2023
Merged

kenjis merged 3 commits into
codeigniter4:developfrom
kenjis:fix-request-getEnv

Conversation

@kenjis

@kenjis kenjis commented Nov 20, 2023

Copy link
Copy Markdown
Member

Description
This method does not work from the beginning, and it was intentional.

    public function index(): string
    {
        dd($this->request->getEnv('CI_ENVIRONMENT'));
    }
$this->request->getEnv(...) null

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added bug Verified issues on the current code behavior or pull requests that will fix them refactor Pull requests that refactor code labels Nov 20, 2023
@kenjis
kenjis force-pushed the fix-request-getEnv branch from 31fabf2 to 606fc9f Compare November 20, 2023 00:44
@kenjis
kenjis force-pushed the fix-request-getEnv branch from 606fc9f to cbb0967 Compare November 20, 2023 00:48
Comment thread system/HTTP/RequestTrait.php Outdated
Co-authored-by: John Paul E. Balandan, CPA <paulbalandan@gmail.com>
@kenjis
kenjis merged commit cfc7ea7 into codeigniter4:develop Nov 22, 2023
@kenjis
kenjis deleted the fix-request-getEnv branch November 22, 2023 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Verified issues on the current code behavior or pull requests that will fix them refactor Pull requests that refactor code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants