Skip to content

docs: fix Database Utility Class getXMLFromResult() - #8276

Merged
kenjis merged 3 commits into
codeigniter4:developfrom
kenjis:fix-docs-db-utils
Nov 30, 2023
Merged

docs: fix Database Utility Class getXMLFromResult()#8276
kenjis merged 3 commits into
codeigniter4:developfrom
kenjis:fix-docs-db-utils

Conversation

@kenjis

@kenjis kenjis commented Nov 30, 2023

Copy link
Copy Markdown
Member

Description

  • fix getXMLFromResult() description
  • add "Initializing the Utility Class"

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the documentation Pull requests for documentation only label Nov 30, 2023
@kenjis kenjis mentioned this pull request Nov 30, 2023
Merged
3 tasks
@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Nov 30, 2023
datamweb
datamweb reviewed Nov 30, 2023
View reviewed changes

@datamweb datamweb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Utility Class also supports generate as CSV, but it is not documented.

@kenjis

kenjis commented Nov 30, 2023

Copy link
Copy Markdown
Member Author

See #8277

paulbalandan
paulbalandan reviewed Nov 30, 2023
View reviewed changes
Comment thread user_guide_src/source/database/utilities/001.php Outdated
Comment thread user_guide_src/source/database/utilities/002.php Outdated
@kenjis
kenjis merged commit c5cb69e into codeigniter4:develop Nov 30, 2023
@kenjis
kenjis deleted the fix-docs-db-utils branch November 30, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes
+1 more reviewer
@datamweb datamweb datamweb left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Verified issues on the current code behavior or pull requests that will fix them documentation Pull requests for documentation only

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kenjis @datamweb @paulbalandan