Skip to content

fix: Handle non-array JSON in validation - #8288

Merged
kenjis merged 2 commits into
codeigniter4:developfrom
woodongwong:fix-Validation-withRequest
Dec 7, 2023
Merged

kenjis merged 2 commits into
codeigniter4:developfrom
woodongwong:fix-Validation-withRequest

Conversation

@woodongwong

@woodongwong woodongwong commented Dec 4, 2023

Copy link
Copy Markdown
Contributor

Description
Continue #8176

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis

kenjis commented Dec 6, 2023

Copy link
Copy Markdown
Member

Can you rebase to pass the Psalm check?

@woodongwong
woodongwong force-pushed the fix-Validation-withRequest branch from 772bfb8 to 4a52e03 Compare December 6, 2023 12:23
@woodongwong
woodongwong force-pushed the fix-Validation-withRequest branch from 4a52e03 to e5c923e Compare December 6, 2023 12:48

@michalsn michalsn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Hopefully, the tests will pass.

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Dec 6, 2023

@kenjis kenjis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kenjis
kenjis merged commit b367f2f into codeigniter4:develop Dec 7, 2023
@woodongwong
woodongwong deleted the fix-Validation-withRequest branch December 7, 2023 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Verified issues on the current code behavior or pull requests that will fix them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants