Skip to content

fix: get_filenames() does not follow symlinks - #8298

Merged
kenjis merged 5 commits into
codeigniter4:developfrom
kenjis:fix-get-filenames-symlink
Dec 7, 2023
Merged

kenjis merged 5 commits into
codeigniter4:developfrom
kenjis:fix-get-filenames-symlink

Conversation

@kenjis

@kenjis kenjis commented Dec 6, 2023

Copy link
Copy Markdown
Member

Description
Supersedes #8225

get_filenames() should follow symlinks.
See #8225 (comment)

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added bug Verified issues on the current code behavior or pull requests that will fix them breaking change Pull requests that may break existing functionalities labels Dec 6, 2023
@kenjis
kenjis force-pushed the fix-get-filenames-symlink branch from 0e5ad52 to bf70e9e Compare December 6, 2023 06:36
@kenjis
kenjis force-pushed the fix-get-filenames-symlink branch from bf70e9e to 3b74ad0 Compare December 6, 2023 09:35
@kenjis
kenjis merged commit b75a73f into codeigniter4:develop Dec 7, 2023
@kenjis
kenjis deleted the fix-get-filenames-symlink branch December 7, 2023 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change Pull requests that may break existing functionalities bug Verified issues on the current code behavior or pull requests that will fix them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants