Skip to content

fix: typo in pager default_simple - #8407

Merged
samsonasik merged 1 commit into
codeigniter4:developfrom
jasonliang-dev:develop
Jan 7, 2024
Merged

samsonasik merged 1 commit into
codeigniter4:developfrom
jasonliang-dev:develop

Conversation

@jasonliang-dev

@jasonliang-dev jasonliang-dev commented Jan 7, 2024

Copy link
Copy Markdown
Contributor

Description
getnext -> getNext

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@michalsn

michalsn commented Jan 7, 2024

Copy link
Copy Markdown
Member

Can you run:

vendor/bin/phpstan analyse --generate-baseline phpstan-baseline.php

to fix the PHPStan error?

@michalsn michalsn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@samsonasik
samsonasik merged commit bbd4f1b into codeigniter4:develop Jan 7, 2024
@samsonasik

Copy link
Copy Markdown
Member

Thank you @jasonliang-dev

@kenjis kenjis added the refactor Pull requests that refactor code label Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Pull requests that refactor code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants