Skip to content

fix: duplicate Cache-Control header with Session #8601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kenjis merged 2 commits into from
Mar 9, 2024
Merged

fix: duplicate Cache-Control header with Session #8601

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64c461f
fix: duplicate Cache-Control header with Session
kenjis Mar 2, 2024
a30e130
docs: fix by proofreading
kenjis Mar 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions system/Config/Services.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -690,6 +690,12 @@ public static function session(?SessionConfig $config = null, bool $getShared =
$session->setLogger($logger);

if (session_status() === PHP_SESSION_NONE) {
// PHP Session emits the headers according to `session.cache_limiter`.
// See https://www.php.net/manual/en/function.session-cache-limiter.php.
// The headers are not managed by CI's Response class.
// So, we remove CI's default Cache-Control header.
AppServices::response()->removeHeader('Cache-Control');

$session->start();
}

Expand Down