refactor: replace PHP_VERSION by PHP_VERSION_ID - #8618
Merged
Merged
Conversation
PHP_VERSION_ID is prefered at CodeIgniter4 repository.
justbyitself
changed the title
Member
|
There is already Could you add to the |
justbyitself
added a commit
to justbyitself/CodeIgniter4
that referenced
this pull request
Mar 11, 2024
justbyitself
added a commit
to justbyitself/CodeIgniter4
that referenced
this pull request
Mar 11, 2024
Member
|
It seems you commit in separate branch, you can commit new change here that the PR include rector.php + code change |
Add Rector rule in order to replace PHP_VERSION by PHP_VERSION_ID. @samsonasik suggestion: codeigniter4#8619
Contributor
Author
|
@samsonasik OK, done. Thank you. |
Member
|
@justbyitself please run the following in your terminal: composer cs-fix
vendor/bin/rector process systemThen commit and push the changes. |
Member
|
Thank you @justbyitself |
Contributor
Author
|
Thank you @samsonasik @paulbalandan @kenjis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP_VERSION_ID is shorter and the most commonly used in this repository.