Replacement of #1652#1663
Merged
Merged
Conversation
lurch
reviewed
Aug 31, 2020
lurch
reviewed
Aug 31, 2020
Contributor
|
Should I go ahead and close #1652 now? |
Collaborator
Closed
lurch
reviewed
Sep 2, 2020
Contributor
|
Perhaps |
Collaborator
|
@lurch any more comments before I merge it? |
Contributor
|
LGTM! |
Contributor
|
Thanks for taking this on @sebweb3r on my behalf 👍 |
Contributor
Author
|
you're welcome 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hijacking the MR of @lurch, since I cannot push into his branch