Allow Array.prototype Augmenting#16
Merged
Merged
Conversation
codler
added a commit
that referenced
this pull request
Jun 24, 2012
Allow Array.prototype Augmenting
Owner
|
Thank you!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This plugin had problems when Array.prototype was augmented (something done by many JavaScript shims, e.g. es5-shim and Augment.js).
My solution was to use
$.eachinstead offor...initeration in several places, which is smarter about avoiding properties from array prototypes.Here's a quick test:
I also bumped the version number to 2.5.