refactor(cargo_provider): cleanup and get rid of potential type errors#1599
Merged
Lee-W merged 6 commits intoNov 30, 2025
Merged
Conversation
bearomorphism
requested review from
Lee-W,
noirbizarre and
woile
as code owners
September 13, 2025 13:23
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v4-10-1 #1599 +/- ##
==========================================
Coverage ? 98.71%
==========================================
Files ? 60
Lines ? 2653
Branches ? 0
==========================================
Hits ? 2619
Misses ? 34
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bearomorphism
force-pushed
the
cargo-provider-refactor
branch
from
September 13, 2025 13:25
de6dcff to
36698e7
Compare
bearomorphism
force-pushed
the
cargo-provider-refactor
branch
from
September 16, 2025 13:38
efb485a to
1c1c09d
Compare
Lee-W
requested changes
Nov 8, 2025
Lee-W
marked this pull request as draft
November 8, 2025 08:26
bearomorphism
force-pushed
the
cargo-provider-refactor
branch
3 times, most recently
from
November 12, 2025 14:46
77ed64e to
4c1ca1d
Compare
bearomorphism
marked this pull request as ready for review
November 12, 2025 14:57
Lee-W
self-requested a review
November 19, 2025 03:27
bearomorphism
force-pushed
the
cargo-provider-refactor
branch
from
November 19, 2025 05:13
4c1ca1d to
0e3d858
Compare
Collaborator
Author
|
Now all |
Lee-W
approved these changes
Nov 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Code Changes
poetry alllocally to ensure this change passes linter check and testsDocumentation Changes
poetry doclocally to ensure the documentation pages renders correctlyExpected Behavior
Steps to Test This Pull Request
Additional Context