Apply customizations to Konflux pipelines for release-v0.2#1399
Merged
Conversation
simonbaird
changed the base branch from
konflux/references/release-v0.2
to
release-v0.2
Member
Author
|
Oops I selected the wrong base. Fixed now. |
Apply changes to the Konflux generated default pipelines. Note there was some manual intervention here. The patch from f1a1972 did not apply since those params were also removed in the release branch pipeline. Ref: https://issues.redhat.com/browse/EC-434 (Commit created with hack/patch-release-pipelines.sh)
simonbaird
force-pushed
the
v02-patch-pipelines
branch
from
6138641 to
f3df3fa
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-v0.2 #1399 +/- ##
================================================
+ Coverage 79.59% 86.82% +7.22%
================================================
Files 62 73 +11
Lines 4347 4682 +335
================================================
+ Hits 3460 4065 +605
+ Misses 887 617 -270
Flags with carried forward coverage won't be shown. Click here to find out more. |
This is failing currently and I don't want to delay getting the release-v0.2 build working. IIUC this is not a hard requirement. Adding a customer EC policy to make this test into only would be a reasonable idea, but right now we don't have a custom EC policy, so it seems more pragmatic to just remove it. EC-464 is filed to bring it back again, (which should be done in main branch to begin with). Ref: https://issues.redhat.com/browse/EC-434 Ref: https://issues.redhat.com/browse/EC-464
simonbaird
changed the title
Member
Author
|
I think it's okay to merge this to get the release branch builds working and passing EC. Potentially we can bring the ecosystem check back quickly if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply changes to the Konflux generated default pipelines.
Note there was some manual intervention here. The patch from f1a1972 did not apply since those params were also removed in the release branch pipeline.
(Commit created with hack/patch-release-pipelines.sh )
Ref: EC-434