Bring back preflight check#1402
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1402 +/- ##
==========================================
+ Coverage 79.59% 86.82% +7.22%
==========================================
Files 62 73 +11
Lines 4347 4682 +335
==========================================
+ Hits 3460 4065 +605
+ Misses 887 617 -270
Flags with carried forward coverage won't be shown. Click here to find out more. |
simonbaird
force-pushed
the
preflight-check
branch
3 times, most recently
from
65d61f3 to
a075f66
Compare
Member
Author
|
Check is passing now. I'll move the PR out of draft. |
simonbaird
force-pushed
the
preflight-check
branch
3 times, most recently
from
7f988fd to
3207b67
Compare
It's expected to be producing two failures currently, but I'm aiming to fix them in some upcoming commits which I'll include in the PR. Ref: https://issues.redhat.com/browse/EC-464
For the finer details about this particular check, see https://github.com/redhat-openshift-ecosystem/openshift-preflight/blob/f19c2a2f587f9890d45ef8b9c13503a4c03f3218/internal/policy/container/has_license.go Ref: https://issues.redhat.com/browse/EC-464
Specifying with a uid since because we're not sure that the 1001 user exists in /etc/passwd, and we get errors otherwise. (To expand on that a little - there is a "default" user with uid 1001 that *does* exist in registry.access.redhat.com/ubi9/go-toolset:latest, but it does not exist in the brew.registry.redhat.io/rh-osbs/openshift-golang-builder base image we're using currently.) There was some discussion about the potential side-effects of this change, particularly if volumes need to be mounted. I'm not 100% confident about it, but maybe it's fine. The goal, once again, is to get the OpenShift preflight check task to stop producing failures. Ref: https://issues.redhat.com/browse/EC-464
simonbaird
force-pushed
the
preflight-check
branch
from
3207b67 to
0ea1374
Compare
Member
Author
|
I got some :button: emojis on slack. Let's merge. |
Member
Author
|
One note: If this does somehow cause problems, it won't impact Konflux prod, since Konflux prod uses the upstream ec image build. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: EC-464