Use source_url not repo_url in git clone task#1419
Merged
Conversation
I'm not sure how or where to confirm it, but the new pipeline created by Konflux uses source_url instead of repo_url, so I'm assuming that is the preferred way to do it, the repo_url is deprecated. Minor followup fix while getting the Konflux pipelines ready in the v0.2 release branch in... Ref: https://issues.redhat.com/browse/EC-434
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1419 +/- ##
==========================================
+ Coverage 79.59% 86.82% +7.22%
==========================================
Files 62 73 +11
Lines 4347 4682 +335
==========================================
+ Hits 3460 4065 +605
+ Misses 887 617 -270
Flags with carried forward coverage won't be shown. Click here to find out more. |
Member
Author
|
I think the ec failure visible here is for the task build and it's likely that the ec check for the cli build is green. Only one of them is visible though due to https://issues.redhat.com/browse/KFLUXBUGS-1147 . |
Member
Author
|
Optimistic merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure how or where to confirm it, but the new pipeline created by Konflux uses source_url instead of repo_url, so I'm assuming that is the preferred way to do it, the repo_url is deprecated.
Minor followup fix while getting the Konflux pipelines ready in the v0.2 release branch in...
Ref: https://issues.redhat.com/browse/EC-434