Skip to content

Use source_url not repo_url in git clone task#1419

Merged
simonbaird merged 1 commit into
conforma:mainfrom
simonbaird:pipline-git-url-var
Mar 8, 2024
Merged

Use source_url not repo_url in git clone task#1419
simonbaird merged 1 commit into
conforma:mainfrom
simonbaird:pipline-git-url-var

Conversation

@simonbaird

Copy link
Copy Markdown
Member

I'm not sure how or where to confirm it, but the new pipeline created by Konflux uses source_url instead of repo_url, so I'm assuming that is the preferred way to do it, the repo_url is deprecated.

Minor followup fix while getting the Konflux pipelines ready in the v0.2 release branch in...
Ref: https://issues.redhat.com/browse/EC-434

I'm not sure how or where to confirm it, but the new pipeline
created by Konflux uses source_url instead of repo_url, so I'm
assuming that is the preferred way to do it, the repo_url is
deprecated.

Minor followup fix while getting the Konflux pipelines ready in
the v0.2 release branch in...
Ref: https://issues.redhat.com/browse/EC-434
@codecov

codecov Bot commented Mar 8, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.82%. Comparing base (eac20a6) to head (25676cd).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1419      +/-   ##
==========================================
+ Coverage   79.59%   86.82%   +7.22%     
==========================================
  Files          62       73      +11     
  Lines        4347     4682     +335     
==========================================
+ Hits         3460     4065     +605     
+ Misses        887      617     -270     
Flag Coverage Δ
acceptance 72.07% <ø> (?)
generative 79.59% <ø> (ø)
integration 79.59% <ø> (ø)
unit 79.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 39 files with indirect coverage changes

@simonbaird

Copy link
Copy Markdown
Member Author

I think the ec failure visible here is for the task build and it's likely that the ec check for the cli build is green.

Only one of them is visible though due to https://issues.redhat.com/browse/KFLUXBUGS-1147 .

@simonbaird

Copy link
Copy Markdown
Member Author

Optimistic merge.

@simonbaird simonbaird merged commit 1a08d7c into conforma:main Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant