Support tracking git references in track bundle#1453
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1453 +/- ##
==========================================
+ Coverage 80.28% 87.16% +6.87%
==========================================
Files 66 77 +11
Lines 4637 5009 +372
==========================================
+ Hits 3723 4366 +643
+ Misses 914 643 -271
Flags with carried forward coverage won't be shown. Click here to find out more.
|
joejstuart
reviewed
Mar 19, 2024
| if err := t.convertToOldFormat(); err != nil { | ||
| return nil, err | ||
| for _, u := range urls { | ||
| repository, rest, found := strings.Cut(u, "//") |
Contributor
There was a problem hiding this comment.
Does this mean we have to specify git+ssh or git+https for task references (used by git resolver) when calling the ec track command?
Contributor
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
Interesting, when handling on the policy side we might ignore whether the scheme is git+ssh or git+https or git+..., we might not care at all about the transfer protocol...
lcarva
approved these changes
Mar 19, 2024
Dates with `0` on the second digit will not be replaced, this leaves dates that are significant, i.e. those in the past or in the far future within the snapshot. Now we can see these significant dates in the snapshots, i.e. we can see that an `effective_on` date is kept the same.
We can use the feature of Cobra to require at least one of `--bundle` or `--input` to be provided.
Contributor
Author
|
Nits were easy to address so merging this now. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also contains some refactoring in separate commits.