Revert "Merge pull request #2150 from zregvart/issue/EC-963"

[robnester-rh]

Revert "Use given source URLs as keys in download cache"

This reverts commit 087f465.

Ref: EC-1023
Signed-off-by: robnester-rh rnester@redhat.com

[codecov]

Codecov Report

Attention: Patch coverage is 71.55172% with 33 lines in your changes missing coverage. Please review.

Project coverage is 71.25%. Comparing base (35654c3) to head (5f47666).
Report is 10 commits behind head on main.

Files with missing lines	Patch %	Lines
internal/policy/policy.go	74.50%	13 Missing ⚠️
cmd/validate/image.go	79.54%	9 Missing ⚠️
internal/policy/source/git_config.go	0.00%	4 Missing ⚠️
internal/evaluation_target/input/input.go	0.00%	3 Missing ⚠️
cmd/fetch/fetch_policy.go	0.00%	2 Missing ⚠️
cmd/inspect/inspect_policy_data.go	0.00%	1 Missing ⚠️
internal/policy/source/source.go	87.50%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2176      +/-   ##
==========================================
+ Coverage   71.22%   71.25%   +0.03%     
==========================================
  Files          89       88       -1     
  Lines        7479     7512      +33     
==========================================
+ Hits         5327     5353      +26     
- Misses       2152     2159       +7     

Flag	Coverage Δ
generative	71.25% <71.55%> (+0.03%)	⬆️
integration	71.25% <71.55%> (+0.03%)	⬆️
unit	71.25% <71.55%> (+0.03%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
cmd/inspect/inspect_policy.go	67.11% <100.00%> (ø)
internal/input/validate.go	77.52% <100.00%> (ø)
cmd/inspect/inspect_policy_data.go	35.45% <0.00%> (ø)
internal/policy/source/source.go	85.38% <87.50%> (+2.80%)	⬆️
cmd/fetch/fetch_policy.go	0.00% <0.00%> (ø)
internal/evaluation_target/input/input.go	0.00% <0.00%> (ø)
internal/policy/source/git_config.go	38.23% <0.00%> (ø)
cmd/validate/image.go	91.83% <79.54%> (ø)
internal/policy/policy.go	79.74% <74.50%> (-0.79%)	⬇️

---- 🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests

[simonbaird]

I think you need to revert the commit that makes the change not the merge commit.

[robnester-rh]

I think you need to revert the commit that makes the change not the merge commit.

Ack. Done.

[lcarva]

/retest

[zregvart]

Perhaps we should comment out the acceptance test scenario that the original PR was trying to fix, otherwise we'll keep getting the same failure.

[robnester-rh]

Perhaps we should comment out the acceptance test scenario that the original PR was trying to fix, otherwise we'll keep getting the same failure.

I've commented out that scenario in the latest commit.