Update ubi9 and go toolset#2545
Merged
Merged
Conversation
Now that the version we want is available, let's use it. See also go.mod, which contains `go 1.23.6`. Similar commits were created already in the v0.5 and v0.6 branches. See PRs conforma#2543 and conforma#2544 . Not really related to, but done while working on... Ref: https://issues.redhat.com/browse/EC-1282
The reasoning behind switching to the :latest tag, is that ubi-minimal is single stream, so as soon as :9.6 is pushed, there are no more updates to :9.5. Using :latest means that we'll (hopefully) continue to get automated digest bump PRs from MintMaker/Renovate. In the unlikely event that something breaks, we'll expect our CI to catch it. Digest copy/pasted from: https://catalog.redhat.com/software/containers/ubi9/ubi-minimal/615bd9b4075b022acc111bf5?container-tabs=gti Note that we need it to be the image index digest, not the digest of the individual image. This should match the digest: skopeo inspect --raw --no-tags docker://registry.access.redhat.com/ubi9/ubi-minimal:latest | sha256sum I ran `hack/update-rpm-lock.sh` but it produced no updates to the lock file, (unlike the v0.5 version, since we install git-core and its dependencies there but not there). Because this brings in the latest rpms (for libtasn1, gnutls and krb5-libs) in the base image it should remove the vulnerabilities listed in... Ref: https://issues.redhat.com/browse/EC-1282
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2545 +/- ##
=======================================
Coverage 68.93% 68.93%
=======================================
Files 101 101
Lines 8534 8534
=======================================
Hits 5883 5883
Misses 2651 2651
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Member
Author
|
Same change was reviewed already elsewhere. Let's merge. |
Member
Author
|
Somehow this didn't trigger an on-push Konflux build. 🤔 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as #2543 and #2544, but now in main branch.
Includes a switch to :latest tag for the base image, and a switch of go-toolset image. See commit messages for more details.
Ref: EC-1282