Skip to content

Update go modules (main) (minor)#3131

Open
renovate[bot] wants to merge 1 commit into
mainfrom
renovate/main-go-modules
Open

Update go modules (main) (minor)#3131
renovate[bot] wants to merge 1 commit into
mainfrom
renovate/main-go-modules

Conversation

@renovate

@renovate renovate Bot commented Feb 27, 2026

Copy link
Copy Markdown
Contributor

ℹ️ Note

This PR body was truncated due to platform limits.

This PR contains the following updates:

Package Change Age Adoption Passing Confidence Type Update
cuelang.org/go v0.16.0v0.17.0 age adoption passing confidence require minor
github.com/CycloneDX/cyclonedx-go v0.10.0v0.11.0 age adoption passing confidence require minor
github.com/conforma/go-containerregistry ae5f0ae8acb20a replace digest
github.com/daixiang0/gci v0.13.7v0.14.0 age adoption passing confidence require minor
github.com/go-openapi/runtime v0.29.2v0.32.4 age adoption passing confidence require minor
github.com/golangci/golangci-lint/v2 v2.11.4v2.12.2 age adoption passing confidence require minor
github.com/konflux-ci/application-api e7eb2ecdd8c9b1 age adoption passing confidence require digest
github.com/open-policy-agent/opa v1.15.2v1.18.1 age adoption passing confidence require minor
github.com/pkg/diff 20ebb0f4e6772a age adoption passing confidence require digest
github.com/secure-systems-lab/go-securesystemslib v0.10.0v0.11.0 age adoption passing confidence require minor
github.com/sigstore/cosign/v3 v3.0.4v3.1.1 age adoption passing confidence require minor
github.com/sigstore/sigstore-go v1.1.4v1.2.1 age adoption passing confidence require minor
github.com/tektoncd/chains v0.26.2v0.27.1 age adoption passing confidence require minor
github.com/tektoncd/cli v0.44.1v0.45.0 age adoption passing confidence require minor
github.com/testcontainers/testcontainers-go v0.34.0v0.43.0 age adoption passing confidence require minor
github.com/testcontainers/testcontainers-go/modules/registry v0.34.0v0.43.0 age adoption passing confidence require minor
github.com/wiremock/go-wiremock v1.11.0v1.16.0 age adoption passing confidence require minor
golang.org/x/benchmarks a2b48b63558132 age adoption passing confidence require digest
golang.org/x/exp 746e56fc48552f age adoption passing confidence require digest
gotest.tools/gotestsum v1.12.1v1.13.0 age adoption passing confidence require minor
k8s.io/kube-openapi 5883c5e8f3fa49 age adoption passing confidence require digest
k8s.io/kubernetes v1.34.2v1.36.2 age adoption passing confidence require minor
sigs.k8s.io/kind v0.26.0v0.32.0 age adoption passing confidence require minor
sigs.k8s.io/kustomize/api v0.20.1v0.21.1 age adoption passing confidence require minor
sigs.k8s.io/kustomize/kyaml v0.20.1v0.21.1 age adoption passing confidence require minor

Release Notes

cue-lang/cue (cuelang.org/go)

v0.17.0

Compare Source

Changes which may break some users are marked below with: ⚠️

Language

The active try experiment renames the new fallback keyword, used with for comprehensions, to otherwise. fallback continues to be accepted for now, but is rewritten to the new form.

The active aliasv2 experiment now allows ~(X) as an alternative to ~X for the single postfix alias form. ~X is also rewritten as ~(X) for the sake of consistency and clarity.

Language versions v0.17.0 and later allow omitting commas in multi-line lists. Just like a newline after a struct field implies a comma, a newline after a list element now implies a comma as well.

Language versions v0.17.0 and later allow a newline or a comma before the closing bracket of an index expression, matching how lists and func arguments allow omitting trailing commas.

The language spec is tweaked to make $ a valid identifier, which was already allowed by the parser and evaluator.

⚠️ Support for the infix div, mod, quo, and rem operators has been removed. Since late 2020, these infix forms have been undocumented and rewritten by cue fix to the new function calls.

The new shortcircuit experiment

This release introduces the shortcircuit experiment, which changes the && and || operators to not evaluate the right operand if the left operand alone determines the result.

This matches the behavior already documented in the CUE spec and is consistent with most mainstream languages, but for the sake of a smooth transition for end users, we are rolling out this change via an experiment.

You can try this experiment via the @experiment(shortcircuit) file attribute. To mimic the old behavior with the experiment, you can use a hidden field:

_y: Y
if X && _y {}

Evaluator

Comprehensions

The comprehension algorithm now waits to run a comprehension's body until the fields it reads have a concrete value, rather than trying to produce its fields up front. This resolves a number of long-standing bugs, most notably the last known regressions from evalv2, where a comprehension that should have resolved instead failed as an incomplete value or a cycle.

This design also greatly simplifies upcoming evaluator work, such as introducing new builtins to replace comparing values to bottom, as well as the design of evalv4.

Other changes

The evaluator no longer deduplicates errors just by position, which was causing some useful errors from disjunctions or standard library calls to be dropped incorrectly.

Several long-standing cycle-detection bugs have been fixed, such as self-referential uses of matchN and matchIf, self-feeding disjunctions, and comprehensions that read a let binding which refers back to the comprehension's own fields.

Fixed a bug where the same package imported via different qualified import paths (e.g. foo.com/bar@v0 or foo.com/bar:baz) did not share the same hidden field namespace.

Resolving an unversioned import from a dependency module now respects that module's own default major version, instead of always using the main module's default.

Fix a number of issues where cue def could produce invalid CUE output, such as due to name conflicts.

Fix an evaluator regression where embedded disjunctions across packages may not correctly apply closedness.

Fix an evaluator bug where cue.Context.BuildExpr of close({}) did not actually result in a closed struct.

Fix a bug where some calls to standard library functions or validators did not include the "error in call to pkg.Func" error context, or included it twice.

A few changes to the evaluator should reduce allocated objects by up to 16%, reducing GC overhead and memory usage.

To ease the transition into the new formatter we plan to release with v0.18, CUE_EXPERIMENT=formatv2=0 is now allowed as a no-op.

A number of other bugs, panics, and hangs have been resolved as well.

cmd/cue

Module replaces

CUE now supports substituting a module dependency with a local directory or a different remote module during development - for example while testing a fix to a dependency before it is published, or to replace a dependency with a fork including improvements.

This configuration lives in cue.mod/local-module.cue, which is excluded when publishing to registries. cue mod edit and cue mod tidy gain support for maintaining this file.

We have also published a how-to guide on replacing a dependency with a local module.

Read the full design doc in the proposal, or read the cue.mod/local-module.cue reference docs.

Other changes

The new global -C or --chdir flag runs cue from the given working directory.

Command input parsing is improved so that CUE packages can come after data files, such as cue vet -c data.yaml ./schema.

cue import --with-context now ensures that data represents the original raw input data, and not its interpretation like JSON Schema.
cue import --path now skips over null values in an input stream, such as empty documents in a YAML file.

Fix a bug where the flag cue export --path was ignored when the inputs were pure CUE.

The new cue exp gengotypes --outfile flag controls the output file path when generating a single package.

cue vet -d/--schema now supports hidden fields, and correctly reports an error when the command inputs are CUE only.

cue fix and cue trim no longer change file modification times when no changes are necessary.

A $CUE_CACHE_DIR directory is no longer required when loading CUE without external dependencies.

The "filetypes" lookup tables now use a more compact encoding, saving about 150KiB in binary size for cmd/cue as well as Go API users.

LSP server

Add an initial version of organize-imports, which sorts the existing imports and removes unneeded imports. It is not yet capable of suggesting missing imports.

Wait for a short period of inactivity before sending diagnostics to the editor. This "debounce" means that a user typing incomplete CUE syntax will not be distracted with syntax errors as much.

The aliasv2 experiment is now fully supported.

The rename function is fixed to distinguish between field names and aliases.

Improve field name analysis in general so that fields with multiple aliases (e.g. v=[k=string]: _) are properly supported.

Improve attribute handling for file-level embedded attributes, and to attach attributes within expressions to the correct struct.

Treat conjunctions (&) and disjunctions (|) the same way for goto-definition. With the cursor on a path, it returns all results that the path MAY resolve to. With the cursor on a field declaration name, it returns all results that the path constructed from the field's name, and its field's name (and so on) MAY resolve to.

Special-case close function calls so that paths can resolve through fields within the argument to close.

Encodings

⚠️ The experimental JSON Schema encoder now emits most definitions without the leading # character, shortening names and ensuring compatibility with the wider JSON Schema ecosystem. This required deprecating encoding/jsonschema.GenerateConfig.NameFunc in favor of NamesFunc.

The JSON Schema encoder is improved to support list.UniqueItems and standalone validators, to use maxItems and minItems instead of maxLength and minLength for lists with prefix elements, and to generate description keywords for doc comments.

Several closedness bugs in the JSON Schema encoder have been fixed, ensuring that the generated JSON Schema behaves the same way as the original CUE definition.

The JSON Schema decoder is improved to better handle the prefixItems keyword.

The ProtoBuf decoder now resolves relative references following the usual scoping rules, instead of always resolving them against the top-level scope.

Standard library

Add time.ToUnix and time.ToUnixNano, which convert an RFC3339Nano time value into seconds or nanoseconds since the Unix epoch, complementing the existing Unix builtin.

strconv.FormatFloat now accepts a string format parameter, like FormatFloat(3.14, "e", 4, 64).

list.MatchN now shows what expected value it's matching against when it fails.

The net IP APIs now consistently return an error on invalid input types.

Go API

Using cue.Values concurrently is now fully supported, which required deprecating cue.Value.Context. If you encounter any races or bugs, please report them via the issue tracker.

cue/load now supports loading from an io/fs.FS, as outlined in proposal #​4285. Loading file embeds through Config.Overlay and Config.FS is supported now as well.

cue/ast/astutil deprecates Sanitize in favor of the new SanitizeFiles API, given that Sanitize on a single file cannot know if another file in the same package shadows builtin names like self.

Add Path.Compare and Selector.Compare, providing allocation-free total ordering suitable for slices.SortFunc.

Clarify that cue/format indents with a tab width of 4 by default.

A new fuzzer has been introduced in the cue package, checking that the parser doesn't crash and that its results are consistent with the rest of the Go APIs like cue/literal. So far, it has already resulted in seventeen bug fixes.

The cue.Interpreter option API has been deprecated in favor of cue.WithInjection, which is a better name going forward.

⚠️ cue/ast.File.Imports, deprecated in mid 2025 in favor of cue/ast.File.ImportSpecs, is now removed.

⚠️ The long-deprecated and hidden cue.Instance methods Lookup, LookupDef, LookupField, and Fill are now removed.

⚠️ The modconfig.Registry interface is changed to report default major versions, which is required for resolving unversioned imports against each dependency module's own defaults. Clients that implement or wrap the interface will need to update. The new interface is future-proofed for upcoming modules changes.

Full list of changes since v0.16.0

Note

PR body was truncated to here.


Configuration

📅 Schedule: (UTC)

  • Branch creation
    • Between 12:00 AM and 03:59 AM (* 0-3 * * *)
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate

renovate Bot commented Feb 27, 2026

Copy link
Copy Markdown
Contributor Author

ℹ️ Artifact update notice

File name: acceptance/go.mod

In order to perform the update(s) described in the table above, Renovate ran the go get command, which resulted in the following additional change(s):

  • 15 additional dependencies were updated
  • The go directive was updated for compatibility reasons

Details:

Package Change
go 1.25.8 -> 1.26.0
github.com/cyphar/filepath-securejoin v0.6.0 -> v0.6.1
github.com/docker/go-connections v0.5.0 -> v0.6.0
github.com/lufia/plan9stats v0.0.0-20240819163618-b1d8f4d146e7 -> v0.0.0-20251013123823-9fd1530e3ec3
github.com/tklauser/go-sysconf v0.3.14 -> v0.3.16
github.com/tklauser/numcpus v0.8.0 -> v0.11.0
golang.org/x/crypto v0.49.0 -> v0.50.0
golang.org/x/mod v0.33.0 -> v0.36.0
golang.org/x/net v0.52.0 -> v0.53.0
golang.org/x/sys v0.42.0 -> v0.43.0
golang.org/x/term v0.41.0 -> v0.42.0
golang.org/x/text v0.35.0 -> v0.36.0
google.golang.org/protobuf v1.36.11 -> v1.36.12-0.20260120151049-f2248ac996af
k8s.io/kube-openapi v0.0.0-20250910181357-589584f1c912 -> v0.0.0-20260317180543-43fb72c5454a
k8s.io/utils v0.0.0-20251002143259-bc988d571ff4 -> v0.0.0-20260210185600-b8788abfbbc2
sigs.k8s.io/structured-merge-diff/v6 v6.3.0 -> v6.3.2
File name: go.mod

In order to perform the update(s) described in the table above, Renovate ran the go get command, which resulted in the following additional change(s):

  • 35 additional dependencies were updated
  • The go directive was updated for compatibility reasons

Details:

Package Change
go 1.25.8 -> 1.26.0
golang.org/x/net v0.52.0 -> v0.54.1-0.20260508232935-23ee2efe81a3
github.com/GoogleCloudPlatform/opentelemetry-operations-go/detectors/gcp v1.30.0 -> v1.31.0
github.com/containerd/containerd/v2 v2.2.2 -> v2.2.3
github.com/decred/dcrd/dcrec/secp256k1/v4 v4.4.0 -> v4.4.1
github.com/docker/go-connections v0.5.0 -> v0.6.0
github.com/goccy/go-json v0.10.5 -> v0.10.6
github.com/grpc-ecosystem/grpc-gateway/v2 v2.27.7 -> v2.28.0
github.com/huandu/go-sqlbuilder v1.39.1 -> v1.40.2
github.com/lestrrat-go/dsig v1.0.0 -> v1.2.1
github.com/lestrrat-go/httprc/v3 v3.0.2 -> v3.0.5
github.com/lestrrat-go/jwx/v3 v3.0.13 -> v3.1.0
github.com/power-devops/perfstat v0.0.0-20210106213030-5aafc221ea8c -> v0.0.0-20240221224432-82ca36839d55
github.com/prometheus/common v0.67.4 -> v0.67.5
github.com/prometheus/procfs v0.17.0 -> v0.20.1
github.com/stretchr/objx v0.5.2 -> v0.5.3
github.com/tklauser/go-sysconf v0.3.12 -> v0.3.16
github.com/tklauser/numcpus v0.6.1 -> v0.11.0
github.com/valyala/fastjson v1.6.7 -> v1.6.10
github.com/yusufpapurcu/wmi v1.2.3 -> v1.2.4
go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.63.0 -> v0.65.0
go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.65.0 -> v0.68.0
go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.40.0 -> v1.43.0
go.opentelemetry.io/proto/otlp v1.9.0 -> v1.10.0
go.yaml.in/yaml/v2 v2.4.3 -> v2.4.4
golang.org/x/crypto v0.49.0 -> v0.51.0
golang.org/x/mod v0.33.0 -> v0.36.0
golang.org/x/sys v0.42.0 -> v0.44.0
golang.org/x/term v0.41.0 -> v0.43.0
golang.org/x/tools v0.42.0 -> v0.45.0
google.golang.org/genproto/googleapis/api v0.0.0-20260203192932-546029d2fa20 -> v0.0.0-20260401024825-9d38bb4040a9
google.golang.org/genproto/googleapis/rpc v0.0.0-20260226221140-a57be14db171 -> v0.0.0-20260401024825-9d38bb4040a9
google.golang.org/grpc v1.79.3 -> v1.80.0
google.golang.org/protobuf v1.36.11 -> v1.36.12-0.20260120151049-f2248ac996af
k8s.io/utils v0.0.0-20251002143259-bc988d571ff4 -> v0.0.0-20260210185600-b8788abfbbc2
sigs.k8s.io/structured-merge-diff/v6 v6.3.0 -> v6.3.2
File name: tools/go.mod

In order to perform the update(s) described in the table above, Renovate ran the go get command, which resulted in the following additional change(s):

  • 48 additional dependencies were updated
  • The go directive was updated for compatibility reasons

Details:

Package Change
go 1.25.8 -> 1.26.0
github.com/Masterminds/semver/v3 v3.4.0 -> v3.5.0
github.com/alecthomas/chroma/v2 v2.23.1 -> v2.24.1
github.com/ashanbrown/forbidigo/v2 v2.3.0 -> v2.3.1
github.com/ashanbrown/makezero/v2 v2.1.0 -> v2.2.1
github.com/bombsimon/wsl/v5 v5.6.0 -> v5.8.0
github.com/butuzov/ireturn v0.4.0 -> v0.4.1
github.com/charmbracelet/colorprofile v0.3.1 -> v0.4.3
github.com/charmbracelet/x/ansi v0.10.1 -> v0.11.7
github.com/charmbracelet/x/term v0.2.1 -> v0.2.2
github.com/clipperhouse/displaywidth v0.6.0 -> v0.11.0
github.com/clipperhouse/uax29/v2 v2.3.0 -> v2.7.0
github.com/cyphar/filepath-securejoin v0.6.0 -> v0.6.1
github.com/dlclark/regexp2 v1.11.5 -> v1.12.0
github.com/golangci/dupl v0.0.0-20250308024227-f665c8d69b32 -> v0.0.0-20260401084720-c99c5cf5c202
github.com/hashicorp/go-version v1.8.0 -> v1.9.0
github.com/jgautheron/goconst v1.8.2 -> v1.10.0
github.com/lib/pq v1.11.2 -> v1.12.3
github.com/lucasb-eyer/go-colorful v1.3.0 -> v1.4.0
github.com/manuelarte/funcorder v0.5.0 -> v0.6.0
github.com/mattn/go-runewidth v0.0.19 -> v0.0.23
github.com/moby/spdystream v0.5.0 -> v0.5.1
github.com/pelletier/go-toml/v2 v2.2.4 -> v2.3.1
github.com/prometheus/procfs v0.17.0 -> v0.19.2
github.com/securego/gosec/v2 v2.24.8-0.20260309165252-619ce2117e08 -> v2.26.1
github.com/sourcegraph/go-diff v0.7.0 -> v0.8.0
github.com/tetafro/godot v1.5.4 -> v1.5.6
github.com/timakin/bodyclose v0.0.0-20241222091800-1db5c5ca4d67 -> v0.0.0-20260129054331-73d1f95b84b4
github.com/uudashr/iface v1.4.1 -> v1.4.2
go-simpler.org/sloglint v0.11.1 -> v0.12.0
go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.63.0 -> v0.65.0
golang.org/x/crypto v0.49.0 -> v0.50.0
golang.org/x/exp v0.0.0-20250911091902-df9299821621 -> v0.0.0-20251219203646-944ab1f22d93
golang.org/x/mod v0.34.0 -> v0.35.0
golang.org/x/net v0.52.0 -> v0.53.0
golang.org/x/sys v0.42.0 -> v0.43.0
golang.org/x/term v0.41.0 -> v0.42.0
golang.org/x/text v0.35.0 -> v0.36.0
golang.org/x/tools v0.43.0 -> v0.44.0
google.golang.org/protobuf v1.36.11 -> v1.36.12-0.20260120151049-f2248ac996af
gopkg.in/evanphx/json-patch.v4 v4.12.0 -> v4.13.0
k8s.io/klog/v2 v2.130.1 -> v2.140.0
k8s.io/kube-openapi v0.0.0-20250710124328-f3f2b991d03b -> v0.0.0-20260317180543-43fb72c5454a
k8s.io/utils v0.0.0-20250820121507-0af2bda4dd1d -> v0.0.0-20260210185600-b8788abfbbc2
sigs.k8s.io/json v0.0.0-20241014173422-cfa47c3a1cc8 -> v0.0.0-20250730193827-2d320260d730
sigs.k8s.io/kustomize/api v0.20.1 -> v0.21.1
sigs.k8s.io/kustomize/cmd/config v0.20.1 -> v0.21.1
sigs.k8s.io/kustomize/kyaml v0.20.1 -> v0.21.1
sigs.k8s.io/structured-merge-diff/v6 v6.3.0 -> v6.3.2
File name: tools/kubectl/go.mod

In order to perform the update(s) described in the table above, Renovate ran the go get command, which resulted in the following additional change(s):

  • 21 additional dependencies were updated
  • The go directive was updated for compatibility reasons

Details:

Package Change
go 1.25.8 -> 1.26.0
github.com/moby/spdystream v0.5.0 -> v0.5.1
github.com/prometheus/common v0.66.1 -> v0.67.5
github.com/prometheus/procfs v0.16.1 -> v0.19.2
github.com/spf13/cobra v1.9.1 -> v1.10.2
github.com/spf13/pflag v1.0.6 -> v1.0.9
go.yaml.in/yaml/v2 v2.4.2 -> v2.4.3
golang.org/x/net v0.43.0 -> v0.49.0
golang.org/x/oauth2 v0.30.0 -> v0.34.0
golang.org/x/sync v0.17.0 -> v0.19.0
golang.org/x/term v0.34.0 -> v0.39.0
golang.org/x/text v0.28.0 -> v0.33.0
google.golang.org/protobuf v1.36.10 -> v1.36.12-0.20260120151049-f2248ac996af
gopkg.in/evanphx/json-patch.v4 v4.12.0 -> v4.13.0
k8s.io/klog/v2 v2.130.1 -> v2.140.0
k8s.io/kube-openapi v0.0.0-20250710124328-f3f2b991d03b -> v0.0.0-20260317180543-43fb72c5454a
k8s.io/utils v0.0.0-20250604170112-4c0f3b243397 -> v0.0.0-20260210185600-b8788abfbbc2
sigs.k8s.io/json v0.0.0-20241014173422-cfa47c3a1cc8 -> v0.0.0-20250730193827-2d320260d730
sigs.k8s.io/kustomize/api v0.20.1 -> v0.21.1
sigs.k8s.io/kustomize/kustomize/v5 v5.7.1 -> v5.8.1
sigs.k8s.io/kustomize/kyaml v0.20.1 -> v0.21.1
sigs.k8s.io/structured-merge-diff/v6 v6.3.0 -> v6.3.2

@renovate renovate Bot added the main label Feb 27, 2026
@renovate renovate Bot force-pushed the renovate/main-go-modules branch 10 times, most recently from b7bbfdc to 02074a5 Compare March 6, 2026 09:52
@renovate renovate Bot force-pushed the renovate/main-go-modules branch 13 times, most recently from ae12a07 to b6bcb99 Compare March 12, 2026 19:21
@renovate renovate Bot force-pushed the renovate/main-go-modules branch 2 times, most recently from eb3bd95 to 50d854b Compare March 15, 2026 12:52

@fullsend-ai-review fullsend-ai-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the review comment for full details.

Comment thread tools/go.mod Outdated
@@ -3,17 +3,17 @@ module github.com/conforma/cli/tools
go 1.25.8

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[low] version-skew

tools/go.mod keeps go 1.25.8 while the other three go.mod files are updated to go 1.26.0. While these are separate Go modules and unlikely to cause immediate issues, it is a hygiene concern.

@fullsend-ai-review

fullsend-ai-review Bot commented Jun 18, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 11:01 PM UTC · Completed 11:10 PM UTC
Commit: 47d3320 · View workflow run →

@fullsend-ai-review

fullsend-ai-review Bot commented Jun 19, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 2:41 AM UTC · Completed 2:49 AM UTC
Commit: 47d3320 · View workflow run →

@fullsend-ai-review

fullsend-ai-review Bot commented Jun 19, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 12:53 PM UTC · Completed 1:03 PM UTC
Commit: 47d3320 · View workflow run →

@fullsend-ai-review fullsend-ai-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the review comment for full details.

@fullsend-ai-review

fullsend-ai-review Bot commented Jun 19, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 5:14 PM UTC · Completed 5:25 PM UTC
Commit: 47d3320 · View workflow run →

@fullsend-ai-review

fullsend-ai-review Bot commented Jun 20, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 6:17 AM UTC · Completed 6:28 AM UTC
Commit: 47d3320 · View workflow run →

@fullsend-ai-review fullsend-ai-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the review comment for full details.

Comment thread go.mod
k8s.io/client-go v0.35.4
k8s.io/klog/v2 v2.130.1
k8s.io/kube-openapi v0.0.0-20250910181357-589584f1c912
github.com/testcontainers/testcontainers-go v0.43.0 // using unreleased version that contains the fix in https://github.com/testcontainers/testcontainers-go/pull/2899

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[critical] API contract violation

testcontainers-go updated from v0.34 to v0.43.0. WithConfigModifier and WithHostConfigModifier were removed in v0.37.0. benchmark/offliner/offliner.go (lines 87, 90) and benchmark/internal/registry/registry.go (lines 131, 154) use these functions, causing compilation failures.

Suggested fix: Either keep testcontainers-go at a version < v0.37.0, or update the benchmark code to use testcontainers.CustomizeRequest instead of the removed modifier functions.

Comment thread acceptance/go.mod
github.com/tektoncd/cli v0.45.0
github.com/tektoncd/pipeline v1.12.0
github.com/testcontainers/testcontainers-go v0.34.0
github.com/testcontainers/testcontainers-go v0.43.0

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[critical] API contract violation

testcontainers-go in acceptance module updated from v0.34.0 to v0.43.0. GenericContainer and GenericContainerRequest removed in v0.37.0. Used in acceptance/git/git.go:183, acceptance/registry/registry.go:112, acceptance/wiremock/wiremock.go:220.

Suggested fix: Either keep testcontainers-go at a version < v0.37.0, or update all acceptance test code to use testcontainers.Run() and the new request builder pattern.

Comment thread go.mod
github.com/google/safearchive v0.0.0-20241025131057-f7ce9d7b6f9c
github.com/hako/durafmt v0.0.0-20210608085754-5c1018a4e16b
github.com/in-toto/in-toto-golang v0.10.0
github.com/in-toto/in-toto-golang v0.11.0

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[medium] API contract violation

in-toto-golang updated from v0.10.0 to v0.11.0. For v0.x libraries, minor bumps can contain breaking changes. Codebase directly imports in_toto types across 17+ files including ProvenanceStatementSLSA02, ProvenanceStatementSLSA1, and Statement.

Suggested fix: Review in-toto-golang v0.11.0 changelog. Run go build ./... to confirm compilation succeeds.

@fullsend-ai-review

fullsend-ai-review Bot commented Jun 20, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 9:59 AM UTC · Completed 10:09 AM UTC
Commit: 47d3320 · View workflow run →

@fullsend-ai-review

fullsend-ai-review Bot commented Jun 21, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 8:58 AM UTC · Completed 9:07 AM UTC
Commit: 47d3320 · View workflow run →

@fullsend-ai-review fullsend-ai-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the review comment for full details.

Comment thread go.mod
golang.org/x/exp v0.0.0-20260410095643-746e56fc9e2f
golang.org/x/net v0.53.0 // indirect
golang.org/x/sync v0.20.0
github.com/testcontainers/testcontainers-go v0.43.0 // using unreleased version that contains the fix in https://github.com/testcontainers/testcontainers-go/pull/2899

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[medium] stale-reference

The comment on the testcontainers-go dependency says using unreleased version but v0.43.0 is a released version, making the comment misleading.

Suggested fix: Remove or update the comment to reflect that v0.43.0 is a released version that includes the fix from PR #2899.

Comment thread acceptance/go.mod Outdated

// Maybe less important in acceptance, but it seems sensible to use the fork here too
replace github.com/google/go-containerregistry => github.com/conforma/go-containerregistry v0.20.7-0.20250703195040-6f40a3734728
replace github.com/google/go-containerregistry => github.com/conforma/go-containerregistry v0.20.7-0.20251103083939-3459088e4bae

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[low] api-contract

The go-containerregistry fork replace directive is updated to a new digest. Verify the new digest still carries all patches.

Suggested fix: Verify that the new fork digest still includes all patches from hack/ec-patches.sh.

@fullsend-ai-review

fullsend-ai-review Bot commented Jun 21, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 2:15 PM UTC · Completed 2:26 PM UTC
Commit: 47d3320 · View workflow run →

@fullsend-ai-review

fullsend-ai-review Bot commented Jun 22, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 11:23 AM UTC · Completed 11:33 AM UTC
Commit: 47d3320 · View workflow run →

@fullsend-ai-review

fullsend-ai-review Bot commented Jun 22, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 1:49 PM UTC · Completed 1:59 PM UTC
Commit: 47d3320 · View workflow run →

@fullsend-ai-review fullsend-ai-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the review comment for full details.

Comment thread acceptance/go.mod
github.com/tektoncd/pipeline v1.12.0
github.com/testcontainers/testcontainers-go v0.34.0
github.com/testcontainers/testcontainers-go v0.43.0
github.com/transparency-dev/merkle v0.0.2

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[medium] API contract violation

The PR updates testcontainers-go from v0.34.0 to v0.43.0 (9-minor-version jump). Acceptance test code uses GenericContainer and Binds field in ContainerRequest, both deprecated in intermediate versions. While Go libraries typically retain deprecated APIs, compatibility should be verified.

Suggested fix: Verify testcontainers-go v0.43.0 still includes GenericContainer and the Binds field. Consider migrating from deprecated APIs in a follow-up.

Comment thread go.mod Outdated
@@ -63,22 +63,22 @@ require (
replace github.com/google/go-containerregistry => github.com/conforma/go-containerregistry v0.20.7-0.20251103083939-3459088e4bae

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[medium] Version consistency

The replace directive for go-containerregistry points to a fork based on v0.20.7, but the required module version is v0.21.6. If the fork lacks APIs added between v0.20.7 and v0.21.6, compile or runtime errors could occur.

Suggested fix: Verify the updated fork commit is compatible with go-containerregistry v0.21.6 APIs used by the codebase.

Comment thread acceptance/go.mod
sigs.k8s.io/kind v0.26.0
sigs.k8s.io/kustomize/api v0.20.1
sigs.k8s.io/kustomize/kyaml v0.20.1
sigs.k8s.io/kind v0.32.0

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[low] Version consistency

sigs.k8s.io/kind updated from v0.26.0 to v0.32.0 -- a large jump. The acceptance tests use versioned v1alpha4 API which is typically stable, but the jump warrants verification.

@fullsend-ai-review

fullsend-ai-review Bot commented Jun 23, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 5:50 AM UTC · Completed 6:01 AM UTC
Commit: 47d3320 · View workflow run →

@fullsend-ai-review

fullsend-ai-review Bot commented Jun 24, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 6:20 AM UTC · Completed 6:30 AM UTC
Commit: 47d3320 · View workflow run →

@fullsend-ai-review fullsend-ai-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the review comment for full details.

Comment thread acceptance/go.mod
github.com/tektoncd/pipeline v1.12.0
github.com/testcontainers/testcontainers-go v0.34.0
github.com/testcontainers/testcontainers-go v0.43.0
github.com/transparency-dev/merkle v0.0.2

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[critical] API contract violation

The PR updates testcontainers-go from v0.34.0 to v0.43.0 in the acceptance module, a 9-minor-version jump. The acceptance module uses testcontainers.GenericContainer in three files: acceptance/git/git.go:183, acceptance/registry/registry.go:112, and acceptance/wiremock/wiremock.go:220. If GenericContainer was removed between v0.35.0 and v0.43.0, these call sites will fail to compile.

Suggested fix: Either (a) pin testcontainers-go to the last version supporting GenericContainer, or (b) migrate all three call sites to use the replacement API (e.g., testcontainers.Run) before merging.

Comment thread go.mod
k8s.io/klog/v2 v2.130.1
k8s.io/kube-openapi v0.0.0-20250910181357-589584f1c912
github.com/testcontainers/testcontainers-go v0.43.0 // using unreleased version that contains the fix in https://github.com/testcontainers/testcontainers-go/pull/2899
github.com/testcontainers/testcontainers-go/modules/registry v0.43.0

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[high] version skew

The main module depends on testcontainers-go/modules/registry at v0.34.0 (line 48), but the PR updates the parent testcontainers-go to v0.43.0. The modules/registry sub-module is versioned in lockstep with the parent module. A v0.34.0 sub-module paired with a v0.43.0 parent will likely cause type incompatibilities at compile time.

Suggested fix: Update github.com/testcontainers/testcontainers-go/modules/registry to v0.43.0 (or the corresponding version that matches the parent module) in go.mod.

Comment thread go.mod
k8s.io/client-go v0.35.4
k8s.io/klog/v2 v2.130.1
k8s.io/kube-openapi v0.0.0-20250910181357-589584f1c912
github.com/testcontainers/testcontainers-go v0.43.0 // using unreleased version that contains the fix in https://github.com/testcontainers/testcontainers-go/pull/2899

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[medium] API contract violation

The main module uses a pinned pseudo-version of testcontainers-go with a comment referencing an unreleased fix (PR #2899). The PR updates this to v0.43.0. The stale comment needs cleanup and the fix inclusion should be verified.

Suggested fix: Verify that the fix from PR #2899 is included in v0.43.0, and remove the stale comment about the unreleased version.

@fullsend-ai-review

fullsend-ai-review Bot commented Jun 25, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 1:13 PM UTC · Completed 1:20 PM UTC
Commit: 47d3320 · View workflow run →

@fullsend-ai-review

fullsend-ai-review Bot commented Jun 25, 2026

Copy link
Copy Markdown

🤖 Finished Review · ❌ Failure · Started 9:14 PM UTC · Completed 9:26 PM UTC
Commit: 47d3320 · View workflow run →

@fullsend-ai-review

fullsend-ai-review Bot commented Jun 26, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 5:24 PM UTC · Completed 5:34 PM UTC
Commit: 47d3320 · View workflow run →

Comment thread go.mod
k8s.io/klog/v2 v2.130.1
k8s.io/kube-openapi v0.0.0-20250910181357-589584f1c912
oras.land/oras-go/v2 v2.6.0
github.com/testcontainers/testcontainers-go v0.43.0 // using unreleased version that contains the fix in https://github.com/testcontainers/testcontainers-go/pull/2899

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[low] stale comment

The PR bumps testcontainers-go from a pre-release pseudo-version (v0.34.1-0.20241204123437-72be13940122) to v0.43.0, a proper release. The inline comment '// using unreleased version that contains the fix in testcontainers/testcontainers-go#2899' becomes factually incorrect and should be removed.

Comment thread tools/go.mod Outdated
@@ -3,17 +3,17 @@ module github.com/conforma/cli/tools
go 1.25.8

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[low] version inconsistency

The Go toolchain version is bumped from 1.25.8 to 1.26.0 in acceptance/go.mod, go.mod, and tools/kubectl/go.mod, but NOT in tools/go.mod which stays at 1.25.8. This may be intentional (separate module with independent constraints), but could lead to inconsistencies.

Suggested fix: Either bump tools/go.mod to go 1.26.0 for consistency, or confirm this divergence is intentional.

@fullsend-ai-review

fullsend-ai-review Bot commented Jun 26, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 8:34 PM UTC · Completed 8:43 PM UTC
Commit: 47d3320 · View workflow run →

Comment thread go.mod
golang.org/x/benchmarks v0.0.0-20241115175113-a2b48b605b42
golang.org/x/exp v0.0.0-20260410095643-746e56fc9e2f
golang.org/x/net v0.55.0 // indirect
github.com/testcontainers/testcontainers-go v0.43.0 // using unreleased version that contains the fix in https://github.com/testcontainers/testcontainers-go/pull/2899

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[low] stale comment

The comment on the testcontainers-go dependency line reads "// using unreleased version that contains the fix in testcontainers/testcontainers-go#2899" but the version is being changed from a pseudo-version (v0.34.1-0.20241204123437-72be13940122) to a proper release (v0.43.0). The comment is now factually incorrect -- v0.43.0 is not an unreleased version.

Suggested fix: Remove or update the comment. If the fix from PR #2899 is confirmed to be in v0.43.0, the comment should be removed entirely.

@fullsend-ai-review

fullsend-ai-review Bot commented Jun 29, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 11:02 AM UTC · Completed 11:15 AM UTC
Commit: 47d3320 · View workflow run →

@fullsend-ai-review

fullsend-ai-review Bot commented Jun 29, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 11:18 AM UTC · Completed 11:30 AM UTC
Commit: 47d3320 · View workflow run →

@fullsend-ai-review

fullsend-ai-review Bot commented Jun 29, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 3:42 PM UTC · Completed 3:54 PM UTC
Commit: 47d3320 · View workflow run →

@fullsend-ai-review fullsend-ai-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the review comment for full details.

Comment thread go.mod
golang.org/x/benchmarks v0.0.0-20241115175113-a2b48b605b42
golang.org/x/exp v0.0.0-20260410095643-746e56fc9e2f
golang.org/x/net v0.55.0 // indirect
github.com/testcontainers/testcontainers-go v0.43.0 // using unreleased version that contains the fix in https://github.com/testcontainers/testcontainers-go/pull/2899

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[critical] API compatibility / compilation failure

testcontainers-go is being updated from v0.34.1 (unreleased pre-v0.35 commit) to v0.43.0. The codebase uses testcontainers.GenericContainer() with testcontainers.GenericContainerRequest in multiple files (acceptance/git/git.go:183, acceptance/registry/registry.go:112, acceptance/wiremock/wiremock.go:220). ContainerRequest.Binds is used in acceptance/git/git.go:174 and acceptance/wiremock/wiremock.go:212. ContainerRequest.AutoRemove is used in acceptance/testenv/testenv.go:252 and extensively tested in acceptance/testenv/testenv_test.go:234,250,264. These APIs were deprecated in testcontainers-go v0.35.0 and removed by v0.43.0, which will cause compilation failures across both the main and acceptance modules.

Suggested fix: Either pin testcontainers-go to a compatible version (e.g., keep v0.34.x), or update all call sites to use the new testcontainers.Run() API, replace Binds with testcontainers.WithHostConfigModifier, and replace AutoRemove with the equivalent new API before merging this version bump.

Comment thread go.mod
golang.org/x/benchmarks v0.0.0-20241115175113-a2b48b605b42
golang.org/x/exp v0.0.0-20260410095643-746e56fc9e2f
golang.org/x/net v0.55.0 // indirect
github.com/testcontainers/testcontainers-go v0.43.0 // using unreleased version that contains the fix in https://github.com/testcontainers/testcontainers-go/pull/2899

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[medium] stale-reference

The comment on the testcontainers-go dependency reads: // using unreleased version that contains the fix in testcontainers/testcontainers-go#2899. Since v0.43.0 is a proper release, this comment is now misleading.

Suggested fix: Remove the comment or update it to note that the fix from PR #2899 is included in the released v0.43.0.

Comment thread go.mod
cuelang.org/go v0.16.0
github.com/CycloneDX/cyclonedx-go v0.10.0
cuelang.org/go v0.17.0
github.com/CycloneDX/cyclonedx-go v0.11.0

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[medium] API compatibility

CycloneDX/cyclonedx-go is being updated from v0.10.0 to v0.11.0 (pre-1.0 library where minor bumps can contain breaking changes). The codebase uses cyclonedx.NewBOMDecoder, cyclonedx.BOM, cyclonedx.BOMFileFormatJSON, cyclonedx.ComponentTypeContainer, bom.Formulation, formulation.Components, and component.Properties in benchmark/offliner/base_images.go:53-73.

Suggested fix: Verify API compatibility by checking the v0.11.0 changelog or running go build ./benchmark/...

Comment thread go.mod
github.com/mitchellh/go-wordwrap v1.0.1
github.com/open-policy-agent/conftest v0.68.2
github.com/open-policy-agent/opa v1.15.2
github.com/open-policy-agent/opa v1.18.1

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[low] API compatibility

OPA is being updated from v1.15.2 to v1.18.1. The codebase imports opa/cmd in cmd/opa/opa.go:19 and uses cmd.RootCommand. Within the v1.x line backward compatibility is maintained, but opa/cmd is an internal-facing package.

Suggested fix: Run go build ./... to verify compilation succeeds with OPA v1.18.1.

Comment thread acceptance/go.mod
sigs.k8s.io/kind v0.26.0
sigs.k8s.io/kustomize/api v0.20.1
sigs.k8s.io/kustomize/kyaml v0.20.1
sigs.k8s.io/kind v0.32.0

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[low] API compatibility

sigs.k8s.io/kind is being updated from v0.26.0 to v0.32.0 (6 minor versions). The codebase uses v1alpha4.Cluster, v1alpha4.Node, v1alpha4.PortMapping, cluster.NewProvider, and related APIs in acceptance/kubernetes/kind/kind.go.

Suggested fix: Run go build ./acceptance/... to verify compilation succeeds with kind v0.32.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file go Pull requests that update Go code main renovate size: XXL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants