Skip to content

Allow not-yet-effective successes in output #939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mbestavros merged 1 commit into from
Aug 15, 2023
Merged

Allow not-yet-effective successes in output #939

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions internal/evaluator/conftest_evaluator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,16 +501,6 @@ func (c conftestEvaluator) computeSuccesses(result Outcome, rules policyRules, e
// Let's omit the solution text here because if the rule is passing
// already then the user probably doesn't care about the solution.

if !isResultEffective(success, effectiveTime) {
log.Debugf("Skipping result success: %#v", success)
continue
}

// Todo maybe: We could also call isResultEffective here for the
// success and skip it if the rule is not yet effective. This would
// require collecting the effective_on value from the custom annotation
// in rule.RuleInfo.

successes = append(successes, success)
}

Expand Down