Produce readable note field in appstudio output#963
Merged
simonbaird merged 1 commit intoAug 24, 2023
Conversation
The appstudio output format includes a note field, which prior to this patch was not populated at all unless there was an error. Let's put at least something in that field. Notes: - I did consider putting an abbreviated verison of the actual failure or warning messges into the note. I think it would be possible, but it's not simple so I decided not to do it here. - There seems to be a usability issue with this. If we output only the appstudio summary, then the failure messages and descriptions are not visible anywhere. There are probabaly some ways to get around that, but let's not try to anticipate what the requirements are.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #963 +/- ##
==========================================
+ Coverage 80.04% 85.42% +5.38%
==========================================
Files 57 64 +7
Lines 4841 5188 +347
==========================================
+ Hits 3875 4432 +557
+ Misses 966 756 -210
Flags with carried forward coverage won't be shown. Click here to find out more.
|
zregvart
approved these changes
Aug 24, 2023
This was referenced Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The appstudio output format includes a note field, which prior to this patch was not populated at all unless there was an error. Let's put at least something in that field.
Notes: